This repository was archived by the owner on Jul 22, 2025. It is now read-only.
DEV: improve artifact editing and eval system #1130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamSaffron
force-pushed
the
eval-edit
branch
from
ca95a10 to
6b3a57a
Compare
nattsw
reviewed
Feb 19, 2025
Comment on lines
+64
to
+69
| content = | ||
| DiscourseAi::Utils::DiffUtils::SimpleDiff.apply( | ||
| content, | ||
| block[:search], | ||
| block[:replace], | ||
| ) |
Contributor
There was a problem hiding this comment.
Is there a chance different blocks might target the same search section?
Member
Author
There was a problem hiding this comment.
yeah llms are crazy... but since this applies it one at a time future replaces will just fail.
my next iteration is going to be hijacking the "stream" and interrupting the llm if it starts misbehaving... but going to leave this to next time
nattsw
approved these changes
Feb 19, 2025
Contributor
nattsw
left a comment
nattsw
left a comment
There was a problem hiding this comment.
Other than that replace question, we can try this out.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.