This repository was archived by the owner on Jul 22, 2025. It is now read-only.
DEV: add summary button wrapper removed from core #1136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CvX
approved these changes
Feb 19, 2025
awesomerobot
added a commit
to discourse/discourse
that referenced
this pull request
Feb 19, 2025
…space (#31391) The `toggle-summary` class is specific to our use in the AI plugin, so I've moved it there in discourse/discourse-ai#1136... This wrapper was occupying some space even though it was empty in the PM topic map, so it's better to not have it. This also allows us to remove some sub-optimal CSS that was adding a gap based on content within it. Without the empty wrapper, we can always have the gap present.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wrapper was in core, but it was removed in discourse/discourse#31391
It makes more sense to keep this in the plugin because it was causing side effects in core.