From e0574e1912e484f33e0bf3b7041b56d76c4d5637 Mon Sep 17 00:00:00 2001
From: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Date: Thu, 20 Mar 2025 01:27:21 +0100
Subject: [PATCH] FIX: prevents fields in Object to re-render

This is a temporary fix while we make this codepath of FormKit to correctly follow Data down action up pattern, re-rendering a component shouldn't be an issue.
---
 .../discourse/components/ai-embedding-editor.gjs         | 9 +++++++--
 .../discourse/components/ai-llm-editor-form.gjs          | 9 +++++++--
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/assets/javascripts/discourse/components/ai-embedding-editor.gjs b/assets/javascripts/discourse/components/ai-embedding-editor.gjs
index d23edd6e9..7f0b55a3e 100644
--- a/assets/javascripts/discourse/components/ai-embedding-editor.gjs
+++ b/assets/javascripts/discourse/components/ai-embedding-editor.gjs
@@ -288,6 +288,11 @@ export default class AiEmbeddingEditor extends Component {
     });
   }
 
+  @action
+  providerKeys(providerParams) {
+    return Object.keys(providerParams);
+  }
+
   <template>
     {{#if this.showPresets}}
       <BackButton
@@ -494,7 +499,7 @@ export default class AiEmbeddingEditor extends Component {
         {{! provider-specific content }}
         {{#if this.currentProvider}}
           <form.Object @name="provider_params" as |object providerData|>
-            {{#each-in providerData as |name|}}
+            {{#each (this.providerKeys providerData) as |name|}}
               {{#let (get this.providerParams name) as |params|}}
                 {{#if params}}
                   <object.Field
@@ -523,7 +528,7 @@ export default class AiEmbeddingEditor extends Component {
                   </object.Field>
                 {{/if}}
               {{/let}}
-            {{/each-in}}
+            {{/each}}
           </form.Object>
         {{/if}}
 
diff --git a/assets/javascripts/discourse/components/ai-llm-editor-form.gjs b/assets/javascripts/discourse/components/ai-llm-editor-form.gjs
index b7fa307fe..16f4cce14 100644
--- a/assets/javascripts/discourse/components/ai-llm-editor-form.gjs
+++ b/assets/javascripts/discourse/components/ai-llm-editor-form.gjs
@@ -250,6 +250,11 @@ export default class AiLlmEditorForm extends Component {
     });
   }
 
+  @action
+  providerParamsKeys(providerParams) {
+    return Object.keys(providerParams);
+  }
+
   <template>
     <Form
       @onSubmit={{this.save}}
@@ -335,7 +340,7 @@ export default class AiLlmEditorForm extends Component {
         </form.Field>
 
         <form.Object @name="provider_params" as |object providerParamsData|>
-          {{#each-in providerParamsData as |name|}}
+          {{#each (this.providerParamsKeys providerParamsData) as |name|}}
             {{#let
               (get (this.metaProviderParams data.provider) name)
               as |params|
@@ -363,7 +368,7 @@ export default class AiLlmEditorForm extends Component {
                 {{/if}}
               </object.Field>
             {{/let}}
-          {{/each-in}}
+          {{/each}}
         </form.Object>
 
         <form.Field