This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FEATURE: allow specifying tool use none in completion prompt #1211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
reviewed
Mar 24, 2025
nattsw
reviewed
Mar 24, 2025
| end | ||
| end | ||
|
|
||
| puts "tool_choice: #{payload[:tool_choice]} - #{dialect.tool_choice}" |
Member
Author
There was a problem hiding this comment.
nope leftover ... oops ... will clean up
nattsw
approved these changes
Mar 24, 2025
Co-authored-by: Natalie Tay <[email protected]>
Member
Author
|
thanks @nattsw |
SamSaffron
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for disabling further tool calls by setting tool_choice to :none across all supported LLM providers:
We previously used to disable tool calls by simply removing tool definitions, but this would cause errors with some providers. This implementation uses the supported method appropriate for each provider while providing a fallback for Bedrock.