This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FIX: Post helper menu results should be selectable #1221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xfalcox
approved these changes
Mar 26, 2025
keegangeorge
added a commit
to discourse/discourse
that referenced
this pull request
Mar 26, 2025
This update adds a new value transformer to the `PostTextSelection` component. This allows for dynamically setting a `preventClose` property. This is useful to prevent the `onSelectionChange` listener from firing a toolbar close. In particular, we want to use this in Discourse AI to prevent the selection change from closing the toolbar when selecting new text inside the explain popup (discourse/discourse-ai#1221)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Overview
This update fixes an issue where the results of the post helper menu was not selectable. Previously, selecting any text inside the menu was immediately closing the menu.
📸 Screenshot
🔗 Relevant Links
https://meta.discourse.org/t/setting-to-manually-close-ai-helpers-popup-modal/358300?u=keegan