From cc458bc19dd0fdb9806c6a32a6183c346295f664 Mon Sep 17 00:00:00 2001 From: Keegan George Date: Wed, 26 Mar 2025 14:13:09 -0700 Subject: [PATCH 1/2] DEV: Remove no longer needed click outside logic --- .../components/admin-report-sentiment-analysis.gjs | 8 -------- 1 file changed, 8 deletions(-) diff --git a/assets/javascripts/discourse/components/admin-report-sentiment-analysis.gjs b/assets/javascripts/discourse/components/admin-report-sentiment-analysis.gjs index ec1b993af..c6fd46697 100644 --- a/assets/javascripts/discourse/components/admin-report-sentiment-analysis.gjs +++ b/assets/javascripts/discourse/components/admin-report-sentiment-analysis.gjs @@ -21,7 +21,6 @@ import discourseLater from "discourse/lib/later"; import { clipboardCopy } from "discourse/lib/utilities"; import Category from "discourse/models/category"; import Post from "discourse/models/post"; -import closeOnClickOutside from "discourse/modifiers/close-on-click-outside"; import { i18n } from "discourse-i18n"; import DTooltip from "float-kit/components/d-tooltip"; import DoughnutChart from "discourse/plugins/discourse-ai/discourse/components/doughnut-chart"; @@ -343,13 +342,6 @@ export default class AdminReportSentimentAnalysis extends Component { class="sentiment-analysis-table__row" role="button" {{on "click" (fn this.showDetails data)}} - {{closeOnClickOutside - (fn (mut this.selectedChart) null) - (hash - targetSelector=".admin-report-sentiment-analysis-details" - secondaryTargetSelector=".admin-report-sentiment-analysis" - ) - }} > {{#if data.category}} From 6c949345b7889e50a985e70300168dc89ca57d0a Mon Sep 17 00:00:00 2001 From: Keegan George Date: Wed, 26 Mar 2025 14:16:12 -0700 Subject: [PATCH 2/2] DEV: import not needed --- .../discourse/components/admin-report-sentiment-analysis.gjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/javascripts/discourse/components/admin-report-sentiment-analysis.gjs b/assets/javascripts/discourse/components/admin-report-sentiment-analysis.gjs index c6fd46697..2623f685a 100644 --- a/assets/javascripts/discourse/components/admin-report-sentiment-analysis.gjs +++ b/assets/javascripts/discourse/components/admin-report-sentiment-analysis.gjs @@ -1,6 +1,6 @@ import Component from "@glimmer/component"; import { tracked } from "@glimmer/tracking"; -import { fn, hash } from "@ember/helper"; +import { fn } from "@ember/helper"; import { on } from "@ember/modifier"; import { action } from "@ember/object"; import didInsert from "@ember/render-modifiers/modifiers/did-insert";