From 79c673e8fbd67db6f49dd05ae6285b9c30cfdc19 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9rgio=20Saquetim?= <saquetim@discourse.org>
Date: Wed, 26 Mar 2025 21:48:26 -0300
Subject: [PATCH 1/2] DEV: Remove the legacy widget post menu code

---
 .../post-menu/ai-cancel-streaming-button.gjs  |  11 +-
 .../components/post-menu/ai-debug-button.gjs  |   7 +-
 .../components/post-menu/ai-share-button.gjs  |  23 +--
 .../initializers/ai-bot-replies.js            |  94 +----------
 spec/system/ai_bot/share_spec.rb              | 156 +++++++++---------
 5 files changed, 90 insertions(+), 201 deletions(-)

diff --git a/assets/javascripts/discourse/components/post-menu/ai-cancel-streaming-button.gjs b/assets/javascripts/discourse/components/post-menu/ai-cancel-streaming-button.gjs
index aa3cef2c0..3fa2170e8 100644
--- a/assets/javascripts/discourse/components/post-menu/ai-cancel-streaming-button.gjs
+++ b/assets/javascripts/discourse/components/post-menu/ai-cancel-streaming-button.gjs
@@ -5,8 +5,10 @@ import { ajax } from "discourse/lib/ajax";
 import { popupAjaxError } from "discourse/lib/ajax-error";
 
 export default class AiCancelStreamingButton extends Component {
-  // TODO (glimmer-post-menu): Remove this static function and move the code into the button action after the widget code is removed
-  static async cancelStreaming(post) {
+  @action
+  async cancelStreaming() {
+    const post = this.args.post;
+
     try {
       await ajax(`/discourse-ai/ai-bot/post/${post.id}/stop-streaming`, {
         type: "POST",
@@ -20,11 +22,6 @@ export default class AiCancelStreamingButton extends Component {
     }
   }
 
-  @action
-  cancelStreaming() {
-    this.constructor.cancelStreaming(this.args.post);
-  }
-
   <template>
     <DButton
       class="post-action-menu__ai-cancel-streaming cancel-streaming"
diff --git a/assets/javascripts/discourse/components/post-menu/ai-debug-button.gjs b/assets/javascripts/discourse/components/post-menu/ai-debug-button.gjs
index fbd214742..5ee57f4e4 100644
--- a/assets/javascripts/discourse/components/post-menu/ai-debug-button.gjs
+++ b/assets/javascripts/discourse/components/post-menu/ai-debug-button.gjs
@@ -10,16 +10,11 @@ export default class AiDebugButton extends Component {
     return isPostFromAiBot(args.post, args.state.currentUser);
   }
 
-  // TODO (glimmer-post-menu): Remove this static function and move the code into the button action after the widget code is removed
-  static debugAiResponse(post, modal) {
-    modal.show(DebugAiModal, { model: post });
-  }
-
   @service modal;
 
   @action
   debugAiResponse() {
-    this.constructor.debugAiResponse(this.args.post, this.modal);
+    this.modal.show(DebugAiModal, { model: this.args.post });
   }
 
   <template>
diff --git a/assets/javascripts/discourse/components/post-menu/ai-share-button.gjs b/assets/javascripts/discourse/components/post-menu/ai-share-button.gjs
index 8cb65ae91..28704e323 100644
--- a/assets/javascripts/discourse/components/post-menu/ai-share-button.gjs
+++ b/assets/javascripts/discourse/components/post-menu/ai-share-button.gjs
@@ -13,27 +13,20 @@ export default class AiDebugButton extends Component {
     return isPostFromAiBot(args.post, args.state.currentUser);
   }
 
-  // TODO (glimmer-post-menu): Remove this static function and move the code into the button action after the widget code is removed
-  static async shareAiResponse(post, modal, showFeedback) {
+  @service modal;
+
+  @action
+  async shareAiResponse() {
+    const post = this.args.post;
+
     if (post.post_number <= AUTO_COPY_THRESHOLD) {
       await copyConversation(post.topic, 1, post.post_number);
-      showFeedback("discourse_ai.ai_bot.conversation_shared");
+      this.args.showFeedback("discourse_ai.ai_bot.conversation_shared");
     } else {
-      modal.show(ShareModal, { model: post });
+      this.modal.show(ShareModal, { model: post });
     }
   }
 
-  @service modal;
-
-  @action
-  shareAiResponse() {
-    this.constructor.shareAiResponse(
-      this.args.post,
-      this.modal,
-      this.args.showFeedback
-    );
-  }
-
   <template>
     <DButton
       class="post-action-menu__share-ai"
diff --git a/assets/javascripts/initializers/ai-bot-replies.js b/assets/javascripts/initializers/ai-bot-replies.js
index b51d2b2c3..0872c2050 100644
--- a/assets/javascripts/initializers/ai-bot-replies.js
+++ b/assets/javascripts/initializers/ai-bot-replies.js
@@ -83,7 +83,7 @@ function initializePersonaDecorator(api) {
 }
 
 function initializePauseButton(api) {
-  const transformerRegistered = api.registerValueTransformer(
+  api.registerValueTransformer(
     "post-menu-buttons",
     ({ value: dag, context: { post, firstButtonKey } }) => {
       if (isGPTBot(post.user)) {
@@ -94,29 +94,6 @@ function initializePauseButton(api) {
       }
     }
   );
-
-  const silencedKey =
-    transformerRegistered && "discourse.post-menu-widget-overrides";
-
-  withSilencedDeprecations(silencedKey, () => initializePauseWidgetButton(api));
-}
-
-function initializePauseWidgetButton(api) {
-  api.addPostMenuButton("cancel-gpt", (post) => {
-    if (isGPTBot(post.user)) {
-      return {
-        icon: "pause",
-        action: "cancelStreaming",
-        title: "discourse_ai.ai_bot.cancel_streaming",
-        className: "btn btn-default cancel-streaming",
-        position: "first",
-      };
-    }
-  });
-
-  api.attachWidgetAction("post", "cancelStreaming", function () {
-    AiCancelStreamingButton.cancelStreaming(this.model);
-  });
 }
 
 function initializeDebugButton(api) {
@@ -125,7 +102,7 @@ function initializeDebugButton(api) {
     return;
   }
 
-  const transformerRegistered = api.registerValueTransformer(
+  api.registerValueTransformer(
     "post-menu-buttons",
     ({ value: dag, context: { post, firstButtonKey } }) => {
       if (post.topic?.archetype === "private_message") {
@@ -136,38 +113,6 @@ function initializeDebugButton(api) {
       }
     }
   );
-
-  const silencedKey =
-    transformerRegistered && "discourse.post-menu-widget-overrides";
-
-  withSilencedDeprecations(silencedKey, () => initializeDebugWidgetButton(api));
-}
-
-function initializeDebugWidgetButton(api) {
-  const currentUser = api.getCurrentUser();
-
-  let debugAiResponse = async function ({ post }) {
-    const modal = api.container.lookup("service:modal");
-    AiDebugButton.debugAiResponse(post, modal);
-  };
-
-  api.addPostMenuButton("debugAi", (post) => {
-    if (post.topic?.archetype !== "private_message") {
-      return;
-    }
-
-    if (!isPostFromAiBot(post, currentUser)) {
-      return;
-    }
-
-    return {
-      action: debugAiResponse,
-      icon: "info",
-      className: "post-action-menu__debug-ai",
-      title: "discourse_ai.ai_bot.debug_ai",
-      position: "first",
-    };
-  });
 }
 
 function initializeShareButton(api) {
@@ -176,7 +121,7 @@ function initializeShareButton(api) {
     return;
   }
 
-  const transformerRegistered = api.registerValueTransformer(
+  api.registerValueTransformer(
     "post-menu-buttons",
     ({ value: dag, context: { post, firstButtonKey } }) => {
       if (post.topic?.archetype === "private_message") {
@@ -186,39 +131,6 @@ function initializeShareButton(api) {
       }
     }
   );
-
-  const silencedKey =
-    transformerRegistered && "discourse.post-menu-widget-overrides";
-
-  withSilencedDeprecations(silencedKey, () => initializeShareWidgetButton(api));
-}
-
-function initializeShareWidgetButton(api) {
-  const currentUser = api.getCurrentUser();
-
-  let shareAiResponse = async function ({ post, showFeedback }) {
-    const modal = api.container.lookup("service:modal");
-    AiShareButton.shareAiResponse(post, modal, showFeedback);
-  };
-
-  api.addPostMenuButton("share", (post) => {
-    // for backwards compat so we don't break if topic is undefined
-    if (post.topic?.archetype !== "private_message") {
-      return;
-    }
-
-    if (!isPostFromAiBot(post, currentUser)) {
-      return;
-    }
-
-    return {
-      action: shareAiResponse,
-      icon: "far-copy",
-      className: "post-action-menu__share-ai",
-      title: "discourse_ai.ai_bot.share",
-      position: "first",
-    };
-  });
 }
 
 function initializeShareTopicButton(api) {
diff --git a/spec/system/ai_bot/share_spec.rb b/spec/system/ai_bot/share_spec.rb
index 06a5c4d14..9e8c68034 100644
--- a/spec/system/ai_bot/share_spec.rb
+++ b/spec/system/ai_bot/share_spec.rb
@@ -43,122 +43,114 @@
     page.execute_script("window.navigator.clipboard.writeText('')")
   end
 
-  glimmer_post_menu_states = %w[enabled disabled]
+  it "can share a conversation with a persona user" do
+    clip_text = nil
 
-  glimmer_post_menu_states.each do |state|
-    context "with the glimmer post menu #{state}" do
-      before { SiteSetting.glimmer_post_menu_mode = state }
+    persona = Fabricate(:ai_persona, name: "Tester")
+    persona.create_user!
 
-      it "can share a conversation with a persona user" do
-        clip_text = nil
+    Fabricate(:post, topic: pm, user: admin, raw: "How do I do stuff?")
+    Fabricate(:post, topic: pm, user: persona.user, raw: "No idea")
 
-        persona = Fabricate(:ai_persona, name: "Tester")
-        persona.create_user!
+    visit(pm.url)
 
-        Fabricate(:post, topic: pm, user: admin, raw: "How do I do stuff?")
-        Fabricate(:post, topic: pm, user: persona.user, raw: "No idea")
+    find("#post_2 .post-action-menu__share-ai").click
 
-        visit(pm.url)
-
-        find("#post_2 .post-action-menu__share-ai").click
-
-        try_until_success do
-          clip_text = cdp.read_clipboard
-          expect(clip_text).not_to eq("")
-        end
+    try_until_success do
+      clip_text = cdp.read_clipboard
+      expect(clip_text).not_to eq("")
+    end
 
-        conversation = (<<~TEXT).strip
-          <details class='ai-quote'>
-          <summary>
-          <span>This is my special PM</span>
-          <span title='Conversation with AI'>AI</span>
-          </summary>
+    conversation = (<<~TEXT).strip
+      <details class='ai-quote'>
+      <summary>
+      <span>This is my special PM</span>
+      <span title='Conversation with AI'>AI</span>
+      </summary>
 
-          **ai_sharer:**
+      **ai_sharer:**
 
-          How do I do stuff?
+      How do I do stuff?
 
-          **Tester_bot:**
+      **Tester_bot:**
 
-          No idea
-          </details>
-        TEXT
+      No idea
+      </details>
+    TEXT
 
-        expect(conversation).to eq(clip_text)
-      end
+    expect(conversation).to eq(clip_text)
+  end
 
-      it "can share a conversation" do
-        clip_text = nil
+  it "can share a conversation" do
+    clip_text = nil
 
-        pm
-        pm_posts
+    pm
+    pm_posts
 
-        visit(pm.url)
+    visit(pm.url)
 
-        find("#post_2 .post-action-menu__share-ai").click
+    find("#post_2 .post-action-menu__share-ai").click
 
-        try_until_success do
-          clip_text = cdp.read_clipboard
-          expect(clip_text).not_to eq("")
-        end
+    try_until_success do
+      clip_text = cdp.read_clipboard
+      expect(clip_text).not_to eq("")
+    end
 
-        conversation = (<<~TEXT).strip
-          <details class='ai-quote'>
-          <summary>
-          <span>This is my special PM</span>
-          <span title='Conversation with AI'>AI</span>
-          </summary>
+    conversation = (<<~TEXT).strip
+      <details class='ai-quote'>
+      <summary>
+      <span>This is my special PM</span>
+      <span title='Conversation with AI'>AI</span>
+      </summary>
 
-          **ai_sharer:**
+      **ai_sharer:**
 
-          test test test user reply 1
+      test test test user reply 1
 
-          **gpt-4:**
+      **gpt-4:**
 
-          test test test bot reply 1
-          </details>
-        TEXT
+      test test test bot reply 1
+      </details>
+    TEXT
 
-        expect(conversation).to eq(clip_text)
+    expect(conversation).to eq(clip_text)
 
-        page.execute_script("window.navigator.clipboard.writeText('')")
+    page.execute_script("window.navigator.clipboard.writeText('')")
 
-        find("#post_6 .post-action-menu__share-ai").click
-        find(".ai-share-modal__slider input").set("2")
-        find(".ai-share-modal button.btn-primary").click
+    find("#post_6 .post-action-menu__share-ai").click
+    find(".ai-share-modal__slider input").set("2")
+    find(".ai-share-modal button.btn-primary").click
 
-        try_until_success do
-          clip_text = cdp.read_clipboard
-          expect(clip_text).not_to eq("")
-        end
+    try_until_success do
+      clip_text = cdp.read_clipboard
+      expect(clip_text).not_to eq("")
+    end
 
-        conversation = (<<~TEXT).strip
-          <details class='ai-quote'>
-          <summary>
-          <span>This is my special PM</span>
-          <span title='Conversation with AI'>AI</span>
-          </summary>
+    conversation = (<<~TEXT).strip
+      <details class='ai-quote'>
+      <summary>
+      <span>This is my special PM</span>
+      <span title='Conversation with AI'>AI</span>
+      </summary>
 
-          **ai_sharer:**
+      **ai_sharer:**
 
-          test test test user reply 2
+      test test test user reply 2
 
-          **gpt-4:**
+      **gpt-4:**
 
-          test test test bot reply 2
+      test test test bot reply 2
 
-          **ai_sharer:**
+      **ai_sharer:**
 
-          test test test user reply 3
+      test test test user reply 3
 
-          **gpt-4:**
+      **gpt-4:**
 
-          test test test bot reply 3
-          </details>
-        TEXT
+      test test test bot reply 3
+      </details>
+    TEXT
 
-        expect(conversation).to eq(clip_text)
-      end
-    end
+    expect(conversation).to eq(clip_text)
   end
 end

From fb2095f6dd6a788d5ad8ca205f0dd3310884e7fe Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9rgio=20Saquetim?= <saquetim@discourse.org>
Date: Wed, 26 Mar 2025 22:04:36 -0300
Subject: [PATCH 2/2] Linting

---
 assets/javascripts/initializers/ai-bot-replies.js | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/assets/javascripts/initializers/ai-bot-replies.js b/assets/javascripts/initializers/ai-bot-replies.js
index 0872c2050..e21878453 100644
--- a/assets/javascripts/initializers/ai-bot-replies.js
+++ b/assets/javascripts/initializers/ai-bot-replies.js
@@ -1,15 +1,11 @@
 import { hbs } from "ember-cli-htmlbars";
-import { withSilencedDeprecations } from "discourse/lib/deprecated";
 import { withPluginApi } from "discourse/lib/plugin-api";
 import { registerWidgetShim } from "discourse/widgets/render-glimmer";
 import AiBotHeaderIcon from "../discourse/components/ai-bot-header-icon";
 import AiCancelStreamingButton from "../discourse/components/post-menu/ai-cancel-streaming-button";
 import AiDebugButton from "../discourse/components/post-menu/ai-debug-button";
 import AiShareButton from "../discourse/components/post-menu/ai-share-button";
-import {
-  isPostFromAiBot,
-  showShareConversationModal,
-} from "../discourse/lib/ai-bot-helper";
+import { showShareConversationModal } from "../discourse/lib/ai-bot-helper";
 import { streamPostText } from "../discourse/lib/ai-streamer/progress-handlers";
 
 let enabledChatBotIds = [];