Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion assets/javascripts/discourse/components/ai-persona-editor.gjs
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,16 @@ export default class PersonaEditor extends Component {

@action
async updateAllGroups() {
this.allGroups = await Group.findAll();
const groups = await Group.findAll({ include_everyone: true });

// Backwards-compatibility code. TODO(roman): Remove 01-09-2025
const hasEveryoneGroup = groups.find((g) => g.id === 0);
if (!hasEveryoneGroup) {
const everyoneGroupName = "everyone";
groups.push({ id: 0, name: everyoneGroupName });
}

this.allGroups = groups;
}

@action
Expand Down
2 changes: 1 addition & 1 deletion db/fixtures/personas/603_ai_personas.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def from_setting(setting_name)
setting_name = "ai_custom_summarization_allowed_groups"
if persona_class == DiscourseAi::Personas::ShortSummarizer
setting_name = "ai_summary_gists_allowed_groups"
default_groups = [] # Blank == everyone
default_groups = [Group::AUTO_GROUPS[:everyone]]
end

persona.allowed_group_ids = from_setting(setting_name).first&.split("|") || default_groups
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# frozen_string_literal: true
class SetCorrectDefaultForShortSummarizerPersona < ActiveRecord::Migration[7.2]
def up
execute <<~SQL
UPDATE ai_personas
SET allowed_group_ids = ARRAY[0]
WHERE id = -12 AND allowed_group_ids = '{}'
SQL
end

def down
raise ActiveRecord::IrreversibleMigration
end
end
4 changes: 2 additions & 2 deletions lib/guardian_extensions.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ def can_see_gists?
return false
end
persona_groups = ai_persona.allowed_group_ids.to_a
return true if persona_groups.empty?
return true if persona_groups.include?(Group::AUTO_GROUPS[:everyone])
return false if anonymous?

ai_persona.allowed_group_ids.to_a.any? { |group_id| user.group_ids.include?(group_id) }
persona_groups.any? { |group_id| user.group_ids.include?(group_id) }
end

def can_request_summary?
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/guardian_extensions_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
end

context "when access is set to everyone" do
before { assign_persona_to(:ai_summary_gists_persona, []) }
before { assign_persona_to(:ai_summary_gists_persona, [Group::AUTO_GROUPS[:everyone]]) }

it "returns true" do
expect(guardian.can_see_gists?).to eq(true)
Expand Down