This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FEATURE: allow tools to amend personas #1250
Merged
+370
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add API methods to AI tools for reading and updating personas, enabling more flexible AI workflows. This allows custom tools to: - Fetch persona information through discourse.getPersona() - Update personas with modified settings via discourse.updatePersona() - Also update using persona.update() These APIs enable new use cases like "trainable" moderation bots, where users with appropriate permissions can set and refine moderation rules through direct chat interactions, without needing admin panel access. Also adds a special API scope which allows people to lean on API for similar actions
nattsw
reviewed
Apr 8, 2025
| persona_id_or_name.to_i.to_s == persona_id_or_name | ||
| persona = AiPersona.find_by(id: persona_id_or_name.to_i) | ||
| else | ||
| persona = AiPersona.find_by(name: persona_id_or_name) |
Contributor
There was a problem hiding this comment.
It looks like name in the AiPersona model is not unique (same for _discourse_get_persona above).
Not sure if you want to add a warning.
Member
Author
There was a problem hiding this comment.
oh it is I can see index_ai_personas_on_name unique, unless I am missing something?
Contributor
There was a problem hiding this comment.
Ah no, it looks like I missed the index below the file.
nattsw
reviewed
Apr 8, 2025
Comment on lines
+520
to
+524
| if updates["temperature"].is_a?(Numeric) | ||
| allowed_updates[:temperature] = updates["temperature"] | ||
| end | ||
|
|
||
| allowed_updates[:top_p] = updates["top_p"] if updates["top_p"].is_a?(Numeric) |
Contributor
There was a problem hiding this comment.
I assume value validations are not in scope?
Member
Author
There was a problem hiding this comment.
tricky, it all runs in JS so it is a custom engine of sorts, will leave it somewhat simple for now if ok
nattsw
approved these changes
Apr 8, 2025
Contributor
nattsw
left a comment
nattsw
left a comment
There was a problem hiding this comment.
Generally looks fine with some comments
This rather powerful hidden feature can allow custom tools to inject content into the context unconditionally it can be used for memory and similar features
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add API methods to AI tools for reading and updating personas, enabling
more flexible AI workflows. This allows custom tools to:
These APIs enable new use cases like "trainable" moderation bots, where
users with appropriate permissions can set and refine moderation rules
through direct chat interactions, without needing admin panel access.
Also adds a special API scope which allows people to lean on API
for similar actions