This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FIX: A typo in bot filtration in ai-bot-header-icon #1455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanrizzi
approved these changes
Jun 20, 2025
Contributor
Author
|
@romanrizzi looks like there's a spec asserting the previous behavior. shall I remove the line entirely instead? |
Member
|
@CvX - Thanks for fixing the typo. The spec failure was legit because we want to display the icon when there's a persona with a default LLM set. This kinda worked thanks to the typo (but will fail when trying to create a topic). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.