This repository was archived by the owner on Jul 22, 2025. It is now read-only.
DEV: Improve AI bot conversation submit upload handling #1497
+32
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-brennan
force-pushed
the
dev/try-fix-in-progress-uploads-flaky
branch
from
6f45efc to
e93eb26
Compare
Try fix a flaky spec in /ai_bot/homepage_spec.rb by using ember data rather than inspecting the DOM directly to see if there are any in-progress uploads. Also add missing translation for in progress uploads warning.
martin-brennan
force-pushed
the
dev/try-fix-in-progress-uploads-flaky
branch
from
e93eb26 to
29a8176
Compare
SamSaffron
approved these changes
Jul 10, 2025
|
wow thanks @martin-brennan 🤗 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try fix a flaky spec in /ai_bot/homepage_spec.rb by using ember
data rather than inspecting the DOM directly to see if there
are any in-progress uploads.
Also add missing translation for in progress uploads warning,
and spec for this behaviour.