DEV: Update rate limits for image captioning

app/controllers/discourse_ai/ai_helper/assistant_controller.rb

@@ -6,7 +6,7 @@ class AssistantController < ::ApplicationController
       requires_plugin ::DiscourseAi::PLUGIN_NAME
       requires_login
       before_action :ensure_can_request_suggestions
-      before_action :rate_limiter_performed!, except: %i[prompts]
+      before_action :rate_limiter_performed!
 
       include SecureUploadEndpointHelpers
 
@@ -161,7 +161,11 @@ def get_post_param!
       end
 
       def rate_limiter_performed!
-        RateLimiter.new(current_user, "ai_assistant", 6, 3.minutes).performed!
+        if action_name == "caption_image"
+          RateLimiter.new(current_user, "ai_assistant_caption_image", 20, 1.minutes).performed!
+        else
+          RateLimiter.new(current_user, "ai_assistant", 6, 3.minutes).performed!
+        end
       end
 
       def ensure_can_request_suggestions

assets/javascripts/initializers/ai-image-caption.js

@@ -111,7 +111,13 @@ export default apiInitializer("1.25.0", (api) => {
       });
       return response.caption;
     } catch (error) {
-      popupAjaxError(error);
+      toasts.error({
+        class: "ai-image-caption-error-toast",
+        duration: 3000,
+        data: {
+          message: I18n.t("discourse_ai.ai_helper.image_caption.error"),
+        },
+      });
     }
   }
 
@@ -129,6 +135,7 @@ export default apiInitializer("1.25.0", (api) => {
     return;
   }
 
+  const toasts = api.container.lookup("service:toasts");
   // Automatically caption uploaded images
   api.addComposerUploadMarkdownResolver(async (upload) => {
     const autoCaptionEnabled = currentUser.get(

config/locales/client.en.yml

@@ -352,6 +352,7 @@ en:
             prompt: "This post contains non-captioned images. Would you like to enable automatic AI captions on image uploads? (This can be changed in your preferences later)"
             confirm: "Enable"
             cancel: "Don't ask again"
+          error: "There was an error generating a caption for the image."
         no_content_error: "Add content first to perform AI actions on it"
 
       reviewables:

spec/requests/ai_helper/assistant_controller_spec.rb

@@ -100,6 +100,20 @@
           expect(response.parsed_body["diff"]).to eq(expected_diff)
         end
       end
+
+      context "when performing numerous requests" do
+        it "rate limits" do
+          RateLimiter.enable
+          6.times do
+            post "/discourse-ai/ai-helper/suggest", params: { mode: mode, text: text_to_proofread }
+            expect(response.status).to eq(200)
+          end
+          DiscourseAi::Completions::Llm.with_prepared_responses([proofread_text]) do
+            post "/discourse-ai/ai-helper/suggest", params: { mode: mode, text: text_to_proofread }
+            expect(response.status).to eq(429)
+          end
+        end
+      end
     end
   end
 
@@ -258,6 +272,21 @@ def request_caption(params)
           end
         end
       end
+
+      context "when performing numerous requests" do
+        it "rate limits" do
+          RateLimiter.enable
+          20.times do
+            request_caption({ image_url: image_url, image_url_type: "long_url" }) do |r|
+              expect(r.status).to eq(200)
+            end
+          end
+
+          request_caption({ image_url: image_url, image_url_type: "long_url" }) do |r|
+            expect(r.status).to eq(429)
+          end
+        end
+      end
     end
   end
 end