FEATURE: new endpoint for directly accessing a persona

[SamSaffron]

The new /admin/plugins/discourse-ai/ai-personas/stream-reply.json was added.

This endpoint streams data direct from a persona and can be used
to access a persona from remote systems leaving a paper trail in
PMs about the conversation that happened

This endpoint is only accessible to admins.

[SamSaffron]

Example usage:

curl -X POST "http://l.discourse:9292/admin/plugins/discourse-ai/ai-personas/stream-reply.json" \
     -H "Content-Type: application/json" \
     -H "Api-Key: SOME_KEY" \
     -H "Api-Username: sam" \
     -d '{
       "persona_name": "DJ Random",
       "query": "how are you?",
       "user_unique_id": "site:test.com:user_id:1",
       "preferred_username": "test_user"
     }' \

{"topic_id":290251,"bot_user_id":-1200,"persona_id":4}

{"partial":"Well"}

{"partial":","}

{"partial":" that"}

{"partial":" was"}

{"partial":" unexpected"}

{"partial":"!"}

{"partial":" It"}

{"partial":" seems"}

{"partial":" even"}

{"partial":" I"}

{"partial":" can"}

{"partial":" be"}

{"partial":" a"}

{"partial":" bit"}

{"partial":" too"}

{"partial":" random"}

{"partial":" sometimes"}

{"partial":"."}

{"partial":" Let's"}

{"partial":" try"}

{"partial":" that"}

{"partial":" again"}

{"partial":":"}

{"partial":" \n\n"}

{"partial":"I'm"}

{"partial":" feeling"}

{"partial":" as"}

{"partial":" random"}

{"partial":" as"}

{"partial":" ever"}

{"partial":","}

{"partial":" ready"}

{"partial":" to"}

{"partial":" pick"}

{"partial":" choices"}

{"partial":" with"}

{"partial":" style"}

{"partial":"!"}

{"partial":" Just"}

{"partial":" let"}

{"partial":" me"}

{"partial":" know"}

{"partial":" what"}

{"partial":" you"}

{"partial":" need"}

{"partial":"."}

{"partial":" 😊"}

[keegangeorge]

LGTM overall, just a few small suggestions

[martin-brennan]

Not sure if further refactors are planned here. I get that we are trying to move fast, but I think there is time to go back and improve things as well.

[martin-brennan]

I see Keegan mentioned a similar thing, but this is an extremely fat controller action, I really don't feel like we should be doing this very often, if ever. It doesn't feel very maintainable or easy to read, and could easily expand even further in size. Much of this is a perfect case for using a service.

[martin-brennan]

The reasons why it's perfect for a service:

• It has model lookups
• It has several parameter validations and error messages
• It has a clear action and result from that action, which could also have more errors

Not saying the reply streaming stuff should be in one, but everything before it easily could be

[SamSaffron]

I have been waiting a bit on service docs and service stability, stuff has been changing recently

[martin-brennan]

Another thing that could be in a service, or at least a reusable class in core. Nothing except the custom field is AI-specific here

[martin-brennan]

I guess it's for a good reason (performance?), but is there any way not to do this writing of headers and data completely manually?

[SamSaffron]

rails has streaming, but I don't want to stream from the foreground thread, I can make wrapper classes for this but at the end the same code will run

[martin-brennan]

Feels like stuff that should be generic/in core/an ActiveSupport::Concern that we could use elsewhere too?

[SamSaffron]

I will move it out to a service at some point definitely do not want a concern here , this is a very sharp knife I only want people that absolutely understand repercussions to use it.