This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FIX: properly bypass CSP for artifacts #920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyb-talks
reviewed
Nov 19, 2024
|
|
||
| response.headers.delete("X-Frame-Options") | ||
| response.headers.delete("Content-Security-Policy") | ||
| response.headers["Content-Security-Policy"] = "script-src 'unsafe-inline';" |
Contributor
There was a problem hiding this comment.
Would using the csp_nonce_placeholder helper work as well? (adding it to the script tag in the html heredoc a few lines above - I think nonce=#{view_context.csp_nonce_placeholder} should work)
tyb-talks
approved these changes
Nov 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent was always to bypass CSP we have no choice with an artifact system and it is sandboxed