This repository was archived by the owner on Jul 22, 2025. It is now read-only.
DEV: improve artifact presentation #932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Keep source in a "details" block after rendered so it does not overwhelm users 2. Ensure artifacts are never indexed by robots 3. Cache break our CSS that changed recently
nattsw
reviewed
Nov 20, 2024
| <meta name="twitter:description" content="<%= @shared_conversation.formatted_excerpt %>"> | ||
| <meta name="viewport" content="width=device-width"> | ||
| <link rel="stylesheet" href="<%= ::UrlHelper.absolute("/plugins/discourse-ai/ai-share/share.css") %>"> | ||
| <link rel="stylesheet" href="<%= ::UrlHelper.absolute("/plugins/discourse-ai/ai-share/share.css?v=1") %>"> |
Member
Author
There was a problem hiding this comment.
old skool cache breaking
nattsw
reviewed
Nov 20, 2024
nattsw
approved these changes
Nov 20, 2024
Contributor
nattsw
left a comment
nattsw
left a comment
There was a problem hiding this comment.
Looks alright for now but unsure if [details] is rendering right. A test would help but will not block.
Member
Author
|
will add a test and merge, thx |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep source in a "details" block after rendered so it does
not overwhelm users
Ensure artifacts are never indexed by robots
Cache break our CSS that changed recently