Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

Conversation

@romanrizzi
Copy link
Member

@romanrizzi romanrizzi commented Nov 20, 2024

Two changes worth mentioning:

  1. .instance returns a fully configured embedding endpoint ready to use.
  2. All endpoints respond to the same method and have the same signature - perform!(text). It's no longer a class method.

This makes it easier to reuse them when generating embeddings in bulk.

@xfalcox
Copy link
Member

xfalcox commented Nov 21, 2024

Why the divide between HuggingFaceText and TeiEmbeddings ? They are the same service, this separation makes it hella confusing.

Also TeiEmbeddings is another case of "Text Embeddings Inference Embeddings"

@romanrizzi
Copy link
Member Author

Why the divide between HuggingFaceText and TeiEmbeddings ? They are the same service, this separation makes it hella confusing.

Also TeiEmbeddings is another case of "Text Embeddings Inference Embeddings"

Fair enough. I'll merge it back but leave rerank and classify as class methods.

Two changes worth mentioning:

`#instance` returns a fully configured embedding endpoint ready to use.
All endpoints respond to the same method and have the same signature - `perform!(text)`

This makes it easier to reuse them when generating embeddings in bulk.
@romanrizzi romanrizzi merged commit 7902125 into main Nov 25, 2024
6 checks passed
@romanrizzi romanrizzi deleted the tidyup_embeddings branch November 25, 2024 16:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants