This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FEATURE: Make emotion /filter ordering match the dashboard table #939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the /filter endpoint use the same criteria we use in the dashboard table for emotion, so it is not confusing for users. It means that only posts made in the period with the emotion shall be shown in the /filter, and the order is simply a count of posts that match the emotion in the period. It also uses a trick to extract the filter period, and apply it to the CTE clause that calculates post emotion count on the period, making it a bit more efficient. Downside is that /filter filters are evaluated from left to right, so it will only get the speed-up if the emotion order is last. As we do this on the dashboard table, it should cover most uses of the ordering, kicking the need for materialized views down the road.
pmusaraj
approved these changes
Nov 21, 2024
Contributor
pmusaraj
left a comment
pmusaraj
left a comment
There was a problem hiding this comment.
Looks good to me, CI test failures look relevant, though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the /filter endpoint use the same criteria we use
in the dashboard table for emotion, so it is not confusing for users.
It means that only posts made in the period with the emotion shall be
shown in the /filter, and the order is simply a count of posts that
match the emotion in the period.
It also uses a trick to extract the filter period, and apply it to
the CTE clause that calculates post emotion count on the period, making
it a bit more efficient. Downside is that /filter filters are evaluated
from left to right, so it will only get the speed-up if the emotion
order is last. As we do this on the dashboard table, it should cover
most uses of the ordering, kicking the need for materialized views
down the road.