Skip to content
This repository was archived by the owner on Jul 14, 2025. It is now read-only.

Commit 6e36963

Browse files
committed
Puts updates behind hidden setting
1 parent d8888c4 commit 6e36963

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

lib/assigner.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -492,7 +492,7 @@ def queue_notification(assignment)
492492
end
493493

494494
def small_action_username_or_name(assign_to)
495-
if (assign_to.is_a?(User) && !SiteSetting.prioritize_username_in_ux) ||
495+
if (assign_to.is_a?(User) && SiteSetting.prioritize_full_name_in_ux) ||
496496
!assign_to.try(:username)
497497
custom_fields = { "action_code_who" => assign_to.name || assign_to.username }
498498
else

spec/system/assign_post_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
before do
1313
skip "Tests are broken and need to be fixed. See https://github.com/discourse/discourse/actions/runs/13890376408/job/38861216842"
1414
SiteSetting.assign_enabled = true
15-
SiteSetting.prioritize_username_in_ux = true
15+
SiteSetting.prioritize_username_in_ux = false
1616
# The system tests in this file are flaky and auth token related so turning this on
1717
SiteSetting.verbose_auth_token_logging = true
1818

@@ -61,7 +61,7 @@ def assign_post(post, assignee)
6161
end
6262

6363
context "when prioritize_full_name_in_ux setting is enabled" do
64-
before { SiteSetting.prioritize_username_in_ux = false }
64+
before { SiteSetting.prioritize_full_name_in_ux = true }
6565

6666
it "shows the user's name after assign" do
6767
visit "/t/#{topic.id}"

spec/system/assign_topic_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
end
5151

5252
context "when prioritize_full_name_in_ux setting is enabled" do
53-
before { SiteSetting.prioritize_username_in_ux = false }
53+
before { SiteSetting.prioritize_full_name_in_ux = true }
5454

5555
it "shows the user's name after assign" do
5656
visit "/t/#{topic.id}"

0 commit comments

Comments
 (0)