FEATURE: Add modifier to assigned count (#598)

* FEATURE: Add modifier to assigned count

* lint: update stree in pending_assigns_reminder_spec

Author: Grubba27

lib/pending_assigns_reminder.rb

@@ -56,10 +56,15 @@ def delete_previous_reminders(user)
   end
 
   def assigned_count_for(user)
-    Assignment
-      .joins_with_topics
-      .where(assigned_to_id: user.id, assigned_to_type: "User", active: true)
-      .count
+    assignments =
+      Assignment.joins_with_topics.where(
+        assigned_to_id: user.id,
+        assigned_to_type: "User",
+        active: true,
+      )
+    assignments =
+      DiscoursePluginRegistry.apply_modifier(:assigned_count_for_user_query, assignments, user)
+    assignments.count
   end
 
   def assigned_topics(user, order:)

spec/lib/pending_assigns_reminder_spec.rb

@@ -143,9 +143,9 @@ def assert_reminder_not_created
       expect(topic.title).to eq(I18n.t("pending_assigns_reminder.title", pending_assignments: 3))
     end
 
-    context "with assigns_reminder_assigned_topics_query" do
+    context "with assigns_reminder_assigned_topics_query modifier" do
       let(:modifier_block) { Proc.new { |query| query.where.not(id: @post1.topic_id) } }
-      it "doesn't remind if topic is solved" do
+      it "updates the query correctly" do
         plugin_instance = Plugin::Instance.new
         plugin_instance.register_modifier(:assigns_reminder_assigned_topics_query, &modifier_block)
         topics = reminder.send(:assigned_topics, user, order: :asc)
@@ -158,5 +158,22 @@ def assert_reminder_not_created
         )
       end
     end
+
+    context "with assigned_count_for_user_query modifier" do
+      let(:modifier_block) { Proc.new { |query, user| query.where.not(assigned_to_id: user.id) } }
+      it "updates the query correctly" do
+        expect(reminder.send(:assigned_count_for, user)).to eq(3)
+
+        plugin_instance = Plugin::Instance.new
+        plugin_instance.register_modifier(:assigned_count_for_user_query, &modifier_block)
+        expect(reminder.send(:assigned_count_for, user)).to eq(0)
+      ensure
+        DiscoursePluginRegistry.unregister_modifier(
+          plugin_instance,
+          :assigned_count_for_user_query,
+          &modifier_block
+        )
+      end
+    end
   end
 end