Skip to content
This repository was archived by the owner on Jul 14, 2025. It is now read-only.

Commit 94b1075

Browse files
fixed failing tests
1 parent 23e6b38 commit 94b1075

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

assets/javascripts/discourse/components/assign-actions-dropdown.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export default class AssignActionsDropdown extends DropdownSelectBoxComponent {
2424
icon: this.group ? "group-times" : "user-xmark",
2525
name: i18n("discourse_assign.unassign.title"),
2626
description: i18n("discourse_assign.unassign.help", {
27-
username: this.assignee, // here
27+
username: this.assignee,
2828
}),
2929
},
3030
{
@@ -45,7 +45,7 @@ export default class AssignActionsDropdown extends DropdownSelectBoxComponent {
4545
icon: assignee.username ? "user-xmark" : "group-times",
4646
name: i18n("discourse_assign.unassign_post.title"),
4747
description: i18n("discourse_assign.unassign_post.help", {
48-
username: assignee.username || assignee.name, // here
48+
username: assignee.username || assignee.name,
4949
}),
5050
});
5151
});

assets/javascripts/discourse/initializers/extend-for-assigns.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,7 @@ function initialize(api) {
479479
}
480480
const icon = iconHTML(assignee.username ? "user-plus" : "group-plus");
481481
let name;
482-
if (siteSettings.prioritize_full_name_in_ux) {
482+
if (siteSettings.prioritize_full_name_in_ux || !assignee.username) {
483483
name = assignee.name;
484484
} else {
485485
name = assignee.username;
@@ -573,13 +573,12 @@ function initialize(api) {
573573
Object.keys(indirectlyAssignedTo).map((postId) => {
574574
const assignee = indirectlyAssignedTo[postId].assigned_to;
575575
const postNumber = indirectlyAssignedTo[postId].post_number;
576-
577-
if (this.siteSettings.prioritize_full_name_in_ux) {
576+
if (this.siteSettings.prioritize_full_name_in_ux || !assignee.username) {
578577
displayedName = assignee.name;
579-
} else {
578+
} else{
580579
displayedName = assignee.username;
581580
}
582-
581+
583582
assigneeElements.push(
584583
h("span.assignee", [
585584
h(

0 commit comments

Comments
 (0)