Skip to content
This repository was archived by the owner on Jul 14, 2025. It is now read-only.

Commit f7714e2

Browse files
committed
DEV: make specs regarding assign button more lenient
in preparation of discourse/discourse#30242 which might make the assign button appear immediately (when it's the only available option) or behind the "..." dropdown.
1 parent 0f4a1fc commit f7714e2

File tree

3 files changed

+22
-3
lines changed

3 files changed

+22
-3
lines changed

test/javascripts/acceptance/assign-disabled-test.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,12 @@ acceptance("Discourse Assign | Assign disabled mobile", function (needs) {
99

1010
test("Footer dropdown does not contain button", async function (assert) {
1111
await visit("/t/internationalization-localization/280");
12-
await click(".topic-footer-mobile-dropdown-trigger");
12+
13+
const dropdown = document.querySelector(".topic-footer-mobile-dropdown-trigger");
14+
if (dropdown) {
15+
await click(dropdown);
16+
}
17+
1318
assert.dom(".assign").doesNotExist();
1419
});
1520
});

test/javascripts/acceptance/assign-enabled-test.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,16 @@ acceptance("Discourse Assign | Assign mobile", function (needs) {
3838

3939
test("Footer dropdown contains button", async function (assert) {
4040
updateCurrentUser({ can_assign: true });
41+
4142
await visit("/t/internationalization-localization/280");
42-
await click(".topic-footer-mobile-dropdown-trigger");
43+
44+
const dropdown = document.querySelector(".topic-footer-mobile-dropdown-trigger");
45+
if (dropdown) {
46+
await click(dropdown);
47+
}
48+
4349
await click(".assign");
50+
4451
assert.dom(".assign.d-modal").exists("assign modal opens");
4552
});
4653
});

test/javascripts/acceptance/assign-enabled-widget-post-menu-test.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,16 @@ acceptance(
4444

4545
test("Footer dropdown contains button", async function (assert) {
4646
updateCurrentUser({ can_assign: true });
47+
4748
await visit("/t/internationalization-localization/280");
48-
await click(".topic-footer-mobile-dropdown-trigger");
49+
50+
const dropdown = document.querySelector(".topic-footer-mobile-dropdown-trigger");
51+
if (dropdown) {
52+
await click(dropdown);
53+
}
54+
4955
await click(".assign");
56+
5057
assert.dom(".assign.d-modal").exists("assign modal opens");
5158
});
5259
}

0 commit comments

Comments
 (0)