DEV: Add lib to autoload path (#130)

Why manually require files when we can autoload? Also update
`discourse-rubocop` and resolve new lint violations.

Author: tgxworld

Gemfile.lock

@@ -1,80 +1,83 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.1.3.3)
+    activesupport (8.0.0)
       base64
+      benchmark (>= 0.3)
       bigdecimal
-      concurrent-ruby (~> 1.0, >= 1.0.2)
+      concurrent-ruby (~> 1.0, >= 1.3.1)
       connection_pool (>= 2.2.5)
       drb
       i18n (>= 1.6, < 2)
+      logger (>= 1.4.2)
       minitest (>= 5.1)
-      mutex_m
-      tzinfo (~> 2.0)
+      securerandom (>= 0.3)
+      tzinfo (~> 2.0, >= 2.0.5)
+      uri (>= 0.13.1)
     ast (2.4.2)
     base64 (0.2.0)
+    benchmark (0.4.0)
     bigdecimal (3.1.8)
-    concurrent-ruby (1.2.3)
+    concurrent-ruby (1.3.4)
     connection_pool (2.4.1)
     drb (2.2.1)
-    i18n (1.14.5)
+    i18n (1.14.6)
       concurrent-ruby (~> 1.0)
-    json (2.7.2)
+    json (2.8.2)
     language_server-protocol (3.17.0.3)
-    minitest (5.23.1)
-    mutex_m (0.2.0)
-    parallel (1.24.0)
-    parser (3.3.1.0)
+    logger (1.6.1)
+    minitest (5.25.1)
+    parallel (1.26.3)
+    parser (3.3.6.0)
       ast (~> 2.4.1)
       racc
     prettier_print (1.2.1)
-    racc (1.8.0)
-    rack (3.0.11)
+    racc (1.8.1)
+    rack (3.1.8)
     rainbow (3.1.1)
     regexp_parser (2.9.2)
-    rexml (3.3.9)
-    rubocop (1.64.0)
+    rubocop (1.68.0)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
+      regexp_parser (>= 2.4, < 3.0)
+      rubocop-ast (>= 1.32.2, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.31.3)
+    rubocop-ast (1.36.1)
       parser (>= 3.3.1.0)
-    rubocop-capybara (2.20.0)
+    rubocop-capybara (2.21.0)
       rubocop (~> 1.41)
-    rubocop-discourse (3.8.0)
+    rubocop-discourse (3.8.6)
       activesupport (>= 6.1)
       rubocop (>= 1.59.0)
       rubocop-capybara (>= 2.0.0)
       rubocop-factory_bot (>= 2.0.0)
       rubocop-rails (>= 2.25.0)
-      rubocop-rspec (>= 2.25.0)
-    rubocop-factory_bot (2.25.1)
-      rubocop (~> 1.41)
-    rubocop-rails (2.25.0)
+      rubocop-rspec (>= 3.0.1)
+      rubocop-rspec_rails (>= 2.30.0)
+    rubocop-factory_bot (2.26.1)
+      rubocop (~> 1.61)
+    rubocop-rails (2.27.0)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
-      rubocop (>= 1.33.0, < 2.0)
+      rubocop (>= 1.52.0, < 2.0)
       rubocop-ast (>= 1.31.1, < 2.0)
-    rubocop-rspec (2.29.2)
-      rubocop (~> 1.40)
-      rubocop-capybara (~> 2.17)
-      rubocop-factory_bot (~> 2.22)
-      rubocop-rspec_rails (~> 2.28)
-    rubocop-rspec_rails (2.28.3)
-      rubocop (~> 1.40)
+    rubocop-rspec (3.2.0)
+      rubocop (~> 1.61)
+    rubocop-rspec_rails (2.30.0)
+      rubocop (~> 1.61)
+      rubocop-rspec (~> 3, >= 3.0.1)
     ruby-progressbar (1.13.0)
+    securerandom (0.3.2)
     syntax_tree (6.2.0)
       prettier_print (>= 1.2.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.5.0)
+    unicode-display_width (2.6.0)
+    uri (1.0.2)
 
 PLATFORMS
   ruby
@@ -84,4 +87,4 @@ DEPENDENCIES
   syntax_tree
 
 BUNDLED WITH
-   2.5.10
+   2.5.18

app/controllers/follow/follow_controller.rb

@@ -3,8 +3,8 @@
 class Follow::FollowController < ApplicationController
   requires_plugin Follow::PLUGIN_NAME
 
-  FOLLOWING ||= :following
-  FOLLOWERS ||= :followers
+  FOLLOWING = :following
+  FOLLOWERS = :followers
 
   def index
   end

config/routes.rb

@@ -9,6 +9,7 @@
       :defaults => {
         format: :json,
       }
+
   delete ":username" => "follow#unfollow",
          :constraints => {
            username: RouteFormat.username,
@@ -17,6 +18,7 @@
          :defaults => {
            format: :json,
          }
+
   get "posts/:username" => "follow#posts",
       :constraints => {
         username: RouteFormat.username,
@@ -26,3 +28,29 @@
         format: :json,
       }
 end
+
+Discourse::Application.routes.draw do
+  mount ::Follow::Engine, at: "follow"
+
+  %w[users u].each_with_index do |root_path, index|
+    get "#{root_path}/:username/follow" => "follow/follow#index",
+        :constraints => {
+          username: RouteFormat.username,
+        }
+
+    get "#{root_path}/:username/follow/feed" => "follow/follow#index",
+        :constraints => {
+          username: RouteFormat.username,
+        }
+
+    get "#{root_path}/:username/follow/following" => "follow/follow#list_following",
+        :constraints => {
+          username: RouteFormat.username,
+        }
+
+    get "#{root_path}/:username/follow/followers" => "follow/follow#list_followers",
+        :constraints => {
+          username: RouteFormat.username,
+        }
+  end
+end

lib/follow/engine.rb

@@ -4,5 +4,6 @@ module ::Follow
   class Engine < ::Rails::Engine
     engine_name "follow"
     isolate_namespace Follow
+    config.autoload_paths << File.join(config.root, "lib")
   end
 end

plugin.rb

@@ -15,47 +15,17 @@
 register_svg_icon "discourse-follow-new-follower"
 register_svg_icon "discourse-follow-new-topic"
 
-require_relative "lib/follow/engine"
-
-Discourse::Application.routes.append do
-  mount ::Follow::Engine, at: "follow"
-  %w[users u].each_with_index do |root_path, index|
-    get "#{root_path}/:username/follow" => "follow/follow#index",
-        :constraints => {
-          username: RouteFormat.username,
-        }
-    get "#{root_path}/:username/follow/feed" => "follow/follow#index",
-        :constraints => {
-          username: RouteFormat.username,
-        }
-
-    get "#{root_path}/:username/follow/following" => "follow/follow#list_following",
-        :constraints => {
-          username: RouteFormat.username,
-        }
-    get "#{root_path}/:username/follow/followers" => "follow/follow#list_followers",
-        :constraints => {
-          username: RouteFormat.username,
-        }
-  end
-end
-
 module ::Follow
   PLUGIN_NAME = "discourse-follow"
 end
 
+require_relative "lib/follow/engine"
+
 after_initialize do
   Notification.types[:following] = 800
   Notification.types[:following_created_topic] = 801
   Notification.types[:following_replied] = 802
 
-  require_relative "lib/follow/notification"
-  require_relative "lib/follow/updater"
-  require_relative "lib/follow/user_extension"
-  require_relative "lib/follow/notification_handler"
-  require_relative "app/controllers/follow/follow_controller"
-  require_relative "config/routes"
-
   reloadable_patch { |plugin| User.prepend(Follow::UserExtension) }
 
   add_to_serializer(:user, :can_see_following) do