Fix off-by-one issue where right arrow wasn't displaying if the last page had only 1 topic. (#68)

Author: nullchristo

javascripts/discourse/components/featured-homepage-topics.gjs

@@ -180,7 +180,7 @@ export default class FeaturedHomepageTopics extends Component {
   get showRightArrow() {
     return (
       this.currentFeaturedTopic <
-      this.featuredTopicsAvailable - this.actualTopicsDisplayed - 1
+      this.featuredTopicsAvailable - this.actualTopicsDisplayed
     );
   }
 

spec/system/pagination_spec.rb

@@ -87,5 +87,25 @@
       expect(page).to have_css(".featured-topics-controls .right-page-button")
       expect(page).to have_css(".featured-topics-controls .left-page-button")
     end
+
+    it "should allow pagination even if last page only has 1 topic" do
+      theme.update_setting(:number_of_topics, 3)
+      theme.update_setting(:max_number_of_topics, 4)
+      theme.save!
+
+      # First page should have a right arrow when there's only 1 topic on the next page
+      visit("/")
+      expect(page).to have_css(".featured-topics .featured-topic", count: 3)
+      expect(page).to have_css(".featured-topics-controls .page-button-container")
+      expect(page).to have_css(".featured-topics-controls .right-page-button")
+      expect(page).not_to have_css(".featured-topics-controls .left-page-button")
+
+      # Last page should only have left arrow
+      find(".featured-topics-controls .right-page-button").click
+      expect(page).to have_css(".featured-topics .featured-topic", count: 1)
+      expect(page).to have_css(".featured-topics-controls .page-button-container")
+      expect(page).not_to have_css(".featured-topics-controls .right-page-button")
+      expect(page).to have_css(".featured-topics-controls .left-page-button")
+    end
   end
 end