DEV: Refactor header icon link rendering and width handling

Rename `buildIcon` to `buildIconTemplate` for clarity and refactor width
parsing to use `Number.isFinite` for safer checks. Streamline conditional
rendering logic for mobile and desktop views, improving code maintainability.

Author: megothss

javascripts/discourse/initializers/initialize-for-header-icon-links.gjs

@@ -7,44 +7,44 @@ import { withPluginApi } from "discourse/lib/plugin-api";
 import { escapeExpression } from "discourse/lib/utilities";
 import isValidUrl from "../lib/isValidUrl";
 
-function buildIcon(iconNameOrImageUrl, title) {
+const beforeIcon = ["chat", "search", "hamburger", "user-menu"];
+
+function buildIconTemplate(iconNameOrImageUrl, title) {
   if (isValidUrl(iconNameOrImageUrl)) {
     return <template>
       <img src={{iconNameOrImageUrl}} aria-hidden="true" />
       <span class="sr-only">{{title}}</span>
     </template>;
-  } else {
-    return <template>{{icon iconNameOrImageUrl label=title}}</template>;
   }
+
+  return <template>{{icon iconNameOrImageUrl label=title}}</template>;
 }
 
 export default {
   name: "header-icon-links",
   initialize() {
     withPluginApi((api) => {
       try {
-        let links = settings.header_links;
+        const links = settings.header_links || [];
 
         links.forEach((link, index) => {
-          const iconTemplate = buildIcon(link.icon, link.title);
+          const iconTemplate = buildIconTemplate(link.icon, link.title);
           const className = `header-icon-${dasherize(link.title)}`;
           const target = link.target === "blank" ? "_blank" : "";
           const rel = link.target ? "noopener" : "";
           const isLastLink =
             index === links.length - 1 ? "last-custom-icon" : "";
 
-          let style;
-          if (link.width && !isNaN(link.width)) {
-            style = htmlSafe(`width: ${escapeExpression(link.width)}px`);
-          }
+          const numericWidth = Number(link.width);
+          const style = Number.isFinite(numericWidth)
+            ? htmlSafe(`width: ${escapeExpression(numericWidth)}px`)
+            : undefined;
 
           const iconComponent = class extends Component {
             static shouldRender(args, context) {
-              if (context.site.mobileView) {
-                return link.view === "vmo" || link.view === "vdm";
-              } else {
-                return link.view === "vdo" || link.view === "vdm";
-              }
+              return context.site.mobileView
+                ? link.view === "vmo" || link.view === "vdm"
+                : link.view === "vdo" || link.view === "vdm";
             }
 
             <template>
@@ -70,8 +70,6 @@ export default {
             </template>
           };
 
-          const beforeIcon = ["chat", "search", "hamburger", "user-menu"];
-
           api.headerIcons.add(link.title, iconComponent, {
             before: beforeIcon,
           });