Skip to content

Commit d601462

Browse files
DEV: Update CI workflows (#10)
Co-authored-by: discoursebuild <[email protected]>
1 parent a1ec910 commit d601462

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

.github/workflows/component-linting.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,18 +20,18 @@ jobs:
2020
- name: Set up Node.js
2121
uses: actions/setup-node@v3
2222
with:
23-
node-version: 16
23+
node-version: 18
2424
cache: yarn
2525

2626
- name: Yarn install
2727
run: yarn install
2828

2929
- name: ESLint
30-
if: ${{ always() }}
30+
if: ${{ !cancelled() }}
3131
run: yarn eslint --ext .js,.js.es6 --no-error-on-unmatched-pattern {test,javascripts}
3232

3333
- name: Prettier
34-
if: ${{ always() }}
34+
if: ${{ !cancelled() }}
3535
shell: bash
3636
run: |
3737
yarn prettier -v
@@ -44,5 +44,5 @@ jobs:
4444
fi
4545
4646
- name: Ember template lint
47-
if: ${{ always() }}
47+
if: ${{ !cancelled() }}
4848
run: yarn ember-template-lint --no-error-on-unmatched-pattern javascripts

.github/workflows/component-tests.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,14 @@ jobs:
139139
if: steps.app-cache.outputs.cache-hit != 'true'
140140
run: rm -rf tmp/app-cache/uploads && cp -r public/uploads tmp/app-cache/uploads
141141

142+
- name: Create theme archive
143+
run: |
144+
cd tmp/component
145+
git archive --format=tar.gz HEAD > ../../theme.tar.gz
146+
142147
- name: Component QUnit
143148
run: |
144149
THEME_NAME=$(ruby -e 'require "json"; puts JSON.parse(File.read("tmp/component/about.json"))["name"]')
145-
bundle exec rake themes:install -- "--{\"$THEME_NAME\": \"tmp/component\"}"
150+
THEME_ARCHIVE=theme.tar.gz bundle exec rake themes:install:archive
146151
UNICORN_TIMEOUT=120 bundle exec rake "themes:qunit[name,$THEME_NAME]"
147152
timeout-minutes: 10

0 commit comments

Comments
 (0)