DEV: Update linting

Author: cvx

Gemfile.lock

@@ -1,7 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (8.0.2)
+    activesupport (8.0.3)
       base64
       benchmark (>= 0.3)
       bigdecimal
@@ -17,45 +17,45 @@ GEM
     ast (2.4.3)
     base64 (0.3.0)
     benchmark (0.4.1)
-    bigdecimal (3.2.0)
+    bigdecimal (3.3.0)
     concurrent-ruby (1.3.5)
-    connection_pool (2.5.3)
+    connection_pool (2.5.4)
     drb (2.2.3)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    json (2.12.2)
+    json (2.15.1)
     language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
     logger (1.7.0)
-    minitest (5.25.5)
+    minitest (5.26.0)
     parallel (1.27.0)
-    parser (3.3.8.0)
+    parser (3.3.9.0)
       ast (~> 2.4.1)
       racc
     prettier_print (1.2.1)
-    prism (1.4.0)
+    prism (1.5.1)
     racc (1.8.1)
-    rack (3.1.16)
+    rack (3.2.2)
     rainbow (3.1.1)
-    regexp_parser (2.10.0)
-    rubocop (1.75.8)
+    regexp_parser (2.11.3)
+    rubocop (1.81.1)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.44.0, < 2.0)
+      rubocop-ast (>= 1.47.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.44.1)
+    rubocop-ast (1.47.1)
       parser (>= 3.3.7.2)
       prism (~> 1.4)
     rubocop-capybara (2.22.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
-    rubocop-discourse (3.12.1)
+    rubocop-discourse (3.13.3)
       activesupport (>= 6.1)
       lint_roller (>= 1.1.0)
       rubocop (>= 1.73.2)
@@ -67,13 +67,13 @@ GEM
     rubocop-factory_bot (2.27.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
-    rubocop-rails (2.32.0)
+    rubocop-rails (2.33.4)
       activesupport (>= 4.2.0)
       lint_roller (~> 1.1)
       rack (>= 1.1)
       rubocop (>= 1.75.0, < 2.0)
       rubocop-ast (>= 1.44.0, < 2.0)
-    rubocop-rspec (3.6.0)
+    rubocop-rspec (3.7.0)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
     rubocop-rspec_rails (2.31.0)
@@ -82,14 +82,14 @@ GEM
       rubocop-rspec (~> 3.5)
     ruby-progressbar (1.13.0)
     securerandom (0.4.1)
-    syntax_tree (6.2.0)
+    syntax_tree (6.3.0)
       prettier_print (>= 1.2.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (3.1.4)
-      unicode-emoji (~> 4.0, >= 4.0.4)
-    unicode-emoji (4.0.4)
-    uri (1.0.3)
+    unicode-display_width (3.2.0)
+      unicode-emoji (~> 4.1)
+    unicode-emoji (4.1.0)
+    uri (1.0.4)
 
 PLATFORMS
   ruby
@@ -99,4 +99,4 @@ DEPENDENCIES
   syntax_tree
 
 BUNDLED WITH
-   2.6.9
+   2.7.2

app/controllers/newsletter_integration/newsletter_subscription_controller.rb

@@ -14,7 +14,7 @@ def subscribe
           newsletter_integration_id: GLOBAL_NEWSLETTER_ID,
         )
       subscription.ensure_active!
-      render json: success_json, status: 200
+      render json: success_json, status: :ok
     end
 
     def unsubscribe
@@ -30,7 +30,7 @@ def unsubscribe
       else
         subscription.ensure_inactive!
       end
-      render json: success_json, status: 200
+      render json: success_json, status: :ok
     end
 
     private

app/controllers/newsletter_integration/webhooks/mailchimp_controller.rb

@@ -13,13 +13,13 @@ class BadSecret < StandardError
     skip_before_action :check_xhr, :redirect_to_login_if_required, :verify_authenticity_token
 
     rescue_from BadSecret do
-      render body: "not ok", status: 404
+      render body: "not ok", status: :not_found
     end
 
     # when a webhook is created on Mailchimp, they test the callback URL with a
     # GET request and expect a 200 response to allow the webhook to be created.
     def verify
-      render body: "ok", status: 200
+      render body: "ok", status: :ok
     end
 
     def sync
@@ -34,7 +34,7 @@ def sync
         desired_active_state = false
       else
         Rails.logger.warn("Mailchimp webhooks controller: unknown event type #{type.inspect}.")
-        render body: "not ok", status: 422
+        render body: "not ok", status: :unprocessable_content
         return
       end
 
@@ -48,7 +48,7 @@ def sync
         subscription.active = desired_active_state
         subscription.save!
       end
-      render body: "ok", status: 200
+      render body: "ok", status: :ok
     end
 
     private

assets/javascripts/discourse/connectors/top-notices/newsletter-banner.gjs

@@ -2,12 +2,12 @@ import Component from "@glimmer/component";
 import { tracked } from "@glimmer/tracking";
 import { action } from "@ember/object";
 import { service } from "@ember/service";
+import { htmlSafe } from "@ember/template";
 import DButton from "discourse/components/d-button";
 import emoji from "discourse/helpers/emoji";
-import getUrl from "discourse/helpers/get-url";
-import htmlSafe from "discourse/helpers/html-safe";
 import { ajax } from "discourse/lib/ajax";
 import { popupAjaxError } from "discourse/lib/ajax-error";
+import getUrl from "discourse/lib/get-url";
 import { i18n } from "discourse-i18n";
 
 export default class NewsletterBanner extends Component {

assets/javascripts/discourse/initializers/setup.js

@@ -4,7 +4,7 @@ export default {
   name: "discourse-newsletter-integration-setup",
 
   initialize() {
-    withPluginApi("1.6.0", (api) => {
+    withPluginApi((api) => {
       const currentUser = api.getCurrentUser();
       if (!currentUser) {
         return;

package.json

@@ -1,11 +1,11 @@
 {
   "private": true,
   "devDependencies": {
-    "@discourse/lint-configs": "2.23.0",
-    "ember-template-lint": "7.7.0",
-    "eslint": "9.28.0",
-    "prettier": "3.5.3",
-    "stylelint": "16.20.0"
+    "@discourse/lint-configs": "2.32.0",
+    "ember-template-lint": "7.9.1",
+    "eslint": "9.37.0",
+    "prettier": "3.6.2",
+    "stylelint": "16.25.0"
   },
   "engines": {
     "node": ">= 22",