DEV: Update linting (#65)

davidtaylorhq · web-flow · commit a67122fa7965 · 2024-11-20T19:25:33.000+01:00
diff --git a/javascripts/connectors/before-list-area/tc-right-sidebar.hbs b/javascripts/connectors/before-list-area/tc-right-sidebar.hbs
@@ -1,4 +1,4 @@
-{{#if showSidebar}}
+{{#if this.showSidebar}}
   <div class="tc-right-sidebar">
     {{right-sidebar-blocks}}
   </div>
diff --git a/javascripts/discourse/components/popular-tags.js b/javascripts/discourse/components/popular-tags.js
@@ -7,6 +7,11 @@ export default class PopularTags extends Component {
   @service router;
   @tracked topTags = null;
 
+  willDestroy() {
+    super.willDestroy(...arguments);
+    this.topTags = null;
+  }
+
   get shouldShowBlock() {
     const currentRoute = this.router.currentRoute;
     const count = this.args?.params?.count || 10;
@@ -49,9 +54,4 @@ export default class PopularTags extends Component {
       displayInSpecificCategories.includes(categoryId)
     );
   }
-
-  willDestroy() {
-    super.willDestroy(...arguments);
-    this.topTags = null;
-  }
 }
diff --git a/javascripts/discourse/components/subcategory-list.js b/javascripts/discourse/components/subcategory-list.js
@@ -6,6 +6,11 @@ export default class SubcategoryList extends Component {
   @service router;
   @tracked parentCategory = null;
 
+  willDestroy() {
+    super.willDestroy(...arguments);
+    this.parentCategory = null;
+  }
+
   get shouldShowBlock() {
     const currentRoute = this.router.currentRoute;
 
@@ -33,9 +38,4 @@ export default class SubcategoryList extends Component {
       displayInCategories.includes(parentCategoryId)
     );
   }
-
-  willDestroy() {
-    super.willDestroy(...arguments);
-    this.parentCategory = null;
-  }
 }
diff --git a/javascripts/discourse/components/top-contributors.js b/javascripts/discourse/components/top-contributors.js
@@ -17,16 +17,16 @@ export default class TopContributors extends Component {
     });
   }
 
+  willDestroy() {
+    super.willDestroy(...arguments);
+    this.topContributors = null;
+  }
+
   get requestURL() {
     return `/directory_items.json?period=${this.period}&order=${this.order}&exclude_groups=${this.excludedGroupNames}&limit=${this.count}`;
   }
 
   get viewAllUrl() {
     return `/u?order=${this.order}&period=${this.period}&exclude_groups=${this.excludedGroupNames}`;
   }
-
-  willDestroy() {
-    super.willDestroy(...arguments);
-    this.topContributors = null;
-  }
 }
diff --git a/javascripts/discourse/templates/components/category-list.hbs b/javascripts/discourse/templates/components/category-list.hbs
@@ -1,9 +1,9 @@
 <h3 class="category-list__heading">
-  {{blockTitle}}
+  {{this.blockTitle}}
 </h3>
 
 <div class="category-list__container">
-  {{#each categoryList as |category|}}
+  {{#each this.categoryList as |category|}}
     <div class="category-list__category">
       {{category-link category}}
     </div>
diff --git a/javascripts/discourse/templates/components/category-topics.hbs b/javascripts/discourse/templates/components/category-topics.hbs
@@ -1,7 +1,7 @@
-{{category-link category}}
+{{category-link this.category}}
 
 <div class="category-topics--content">
-  {{#each topics as |topic|}}
+  {{#each this.topics as |topic|}}
     <a href={{topic.url}} class="category-topics--topic">
       {{html-safe (replace-emoji topic.fancy_title)}}
       <span class="category-topics--posts-count">
diff --git a/javascripts/discourse/templates/components/custom-html-rsb.hbs b/javascripts/discourse/templates/components/custom-html-rsb.hbs
@@ -1 +1 @@
-{{html-safe params.content}}
+{{html-safe this.params.content}}
diff --git a/javascripts/discourse/templates/components/popular-tags.hbs b/javascripts/discourse/templates/components/popular-tags.hbs
@@ -1,10 +1,10 @@
-{{#if shouldShowBlock}}
+{{#if this.shouldShowBlock}}
   <h3 class="popular-tags-heading">
     {{theme-i18n "popular_tags.heading"}}
   </h3>
 
   <div class="popular-tags__container">
-    {{#each topTags as |t|}}
+    {{#each this.topTags as |t|}}
       <a href="/tag/{{t}}" class="popular-tags__tag">
         {{t}}
       </a>
diff --git a/javascripts/discourse/templates/components/recent-replies.hbs b/javascripts/discourse/templates/components/recent-replies.hbs
@@ -3,7 +3,7 @@
 </h3>
 
 <div class="recent-replies--container">
-  {{#each replies as |reply|}}
+  {{#each this.replies as |reply|}}
     <div class="recent-replies--reply">
       <div class="recent-replies--col">
         {{avatar reply imageSize="small"}}
diff --git a/javascripts/discourse/templates/components/right-sidebar-blocks.hbs b/javascripts/discourse/templates/components/right-sidebar-blocks.hbs
@@ -1,6 +1,6 @@
 <PluginOutlet @name="above-right-sidebar-blocks" />
 
-{{#each blocks as |block|}}
+{{#each this.blocks as |block|}}
   <div class={{block.classNames}}>
     {{component block.internalName params=block.parsedParams}}
   </div>
diff --git a/javascripts/discourse/templates/components/tag-topics.hbs b/javascripts/discourse/templates/components/tag-topics.hbs
@@ -1,9 +1,9 @@
 <h3 class="tag-topics__heading">
-  {{blockTitle}}
+  {{this.blockTitle}}
 </h3>
 
 <div class="tag-topics__container">
-  {{#each tagTopics as |topic|}}
+  {{#each this.tagTopics as |topic|}}
     <div class="tag-topics__topic">
       <div class="tag-topics__col">
         <div class="tag-topics__topic-title">
diff --git a/javascripts/discourse/templates/components/top-contributors.hbs b/javascripts/discourse/templates/components/top-contributors.hbs
@@ -3,14 +3,14 @@
 </h3>
 
 <div class="top-contributors--container">
-  {{#each topContributors as |item|}}
+  {{#each this.topContributors as |item|}}
     <div class="top-contributors--user">
       <span
         data-user-card={{item.user.username}}
         class="top-contributors--user-badge"
       >
         {{avatar item.user imageSize="small"}}
-        {{#if siteSettings.prioritize_username_in_ux}}
+        {{#if this.siteSettings.prioritize_username_in_ux}}
           {{item.user.username}}
         {{else if item.user.name}}
           {{item.user.name}}
diff --git a/javascripts/discourse/templates/components/top-topics.hbs b/javascripts/discourse/templates/components/top-topics.hbs
@@ -3,7 +3,7 @@
 </h3>
 
 <div class="top-topics__container">
-  {{#each topTopics as |topic|}}
+  {{#each this.topTopics as |topic|}}
     <div class="top-topics__topic">
       <div class="top-topics__col">
         <div class="top-topics__topic-title">
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "private": true,
   "devDependencies": {
-    "@discourse/lint-configs": "2.0.1",
+    "@discourse/lint-configs": "2.2.1",
     "ember-template-lint": "6.0.0",
     "eslint": "9.14.0",
     "prettier": "2.8.8"
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-{{#if showSidebar}}`
	`1`	`+{{#if this.showSidebar}}`
`2`	`2`	`<div class="tc-right-sidebar">`
`3`	`3`	`{{right-sidebar-blocks}}`
`4`	`4`	`</div>`
Original file line number	Diff line number	Diff line change
`@@ -17,16 +17,16 @@ export default class TopContributors extends Component {`
`17`	`17`	`});`
`18`	`18`	`}`
`19`	`19`
	`20`	`+ willDestroy() {`
	`21`	`+ super.willDestroy(...arguments);`
	`22`	`+ this.topContributors = null;`
	`23`	`+ }`
	`24`	`+`
`20`	`25`	`get requestURL() {`
`21`	`26`	return `/directory_items.json?period=${this.period}&order=${this.order}&exclude_groups=${this.excludedGroupNames}&limit=${this.count}`;
`22`	`27`	`}`
`23`	`28`
`24`	`29`	`get viewAllUrl() {`
`25`	`30`	return `/u?order=${this.order}&period=${this.period}&exclude_groups=${this.excludedGroupNames}`;
`26`	`31`	`}`
`27`		`-`
`28`		`- willDestroy() {`
`29`		`- super.willDestroy(...arguments);`
`30`		`- this.topContributors = null;`
`31`		`- }`
`32`	`32`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{{html-safe params.content}}`
	`1`	`+{{html-safe this.params.content}}`