DEV: Update linting and add types (#139)

Author: cvx

.gitignore

@@ -1,3 +1,4 @@
 node_modules
 /gems
 /auto_generated
+.eslintcache

Gemfile.lock

@@ -1,82 +1,84 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (8.0.3)
+    activesupport (8.1.2)
       base64
-      benchmark (>= 0.3)
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.3.1)
       connection_pool (>= 2.2.5)
       drb
       i18n (>= 1.6, < 2)
+      json
       logger (>= 1.4.2)
       minitest (>= 5.1)
       securerandom (>= 0.3)
       tzinfo (~> 2.0, >= 2.0.5)
       uri (>= 0.13.1)
     ast (2.4.3)
     base64 (0.3.0)
-    benchmark (0.4.1)
-    bigdecimal (3.3.0)
-    concurrent-ruby (1.3.5)
-    connection_pool (2.5.4)
+    bigdecimal (4.0.1)
+    concurrent-ruby (1.3.6)
+    connection_pool (3.0.2)
     drb (2.2.3)
-    i18n (1.14.7)
+    i18n (1.14.8)
       concurrent-ruby (~> 1.0)
-    json (2.15.1)
+    json (2.18.0)
     language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
     logger (1.7.0)
-    minitest (5.26.0)
+    minitest (6.0.1)
+      prism (~> 1.5)
     parallel (1.27.0)
-    parser (3.3.9.0)
+    parser (3.3.10.1)
       ast (~> 2.4.1)
       racc
     prettier_print (1.2.1)
-    prism (1.5.1)
+    prism (1.8.0)
     racc (1.8.1)
-    rack (3.2.3)
+    rack (3.2.4)
     rainbow (3.1.1)
     regexp_parser (2.11.3)
-    rubocop (1.81.1)
+    rubocop (1.84.0)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.47.1, < 2.0)
+      rubocop-ast (>= 1.49.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.47.1)
+    rubocop-ast (1.49.0)
       parser (>= 3.3.7.2)
-      prism (~> 1.4)
+      prism (~> 1.7)
     rubocop-capybara (2.22.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
-    rubocop-discourse (3.13.3)
+    rubocop-discourse (3.14.0)
       activesupport (>= 6.1)
       lint_roller (>= 1.1.0)
-      rubocop (>= 1.73.2)
       rubocop-capybara (>= 2.22.0)
+      rubocop-discourse-base (>= 1.0.0)
       rubocop-factory_bot (>= 2.27.0)
       rubocop-rails (>= 2.30.3)
       rubocop-rspec (>= 3.0.1)
       rubocop-rspec_rails (>= 2.31.0)
-    rubocop-factory_bot (2.27.1)
+    rubocop-discourse-base (1.0.0)
+      rubocop (>= 1.80.0)
+    rubocop-factory_bot (2.28.0)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
-    rubocop-rails (2.33.4)
+    rubocop-rails (2.34.3)
       activesupport (>= 4.2.0)
       lint_roller (~> 1.1)
       rack (>= 1.1)
       rubocop (>= 1.75.0, < 2.0)
       rubocop-ast (>= 1.44.0, < 2.0)
-    rubocop-rspec (3.7.0)
+    rubocop-rspec (3.9.0)
       lint_roller (~> 1.1)
-      rubocop (~> 1.72, >= 1.72.1)
-    rubocop-rspec_rails (2.31.0)
+      rubocop (~> 1.81)
+    rubocop-rspec_rails (2.32.0)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
       rubocop-rspec (~> 3.5)
@@ -88,8 +90,8 @@ GEM
       concurrent-ruby (~> 1.0)
     unicode-display_width (3.2.0)
       unicode-emoji (~> 4.1)
-    unicode-emoji (4.1.0)
-    uri (1.0.4)
+    unicode-emoji (4.2.0)
+    uri (1.1.1)
 
 PLATFORMS
   ruby
@@ -99,4 +101,4 @@ DEPENDENCIES
   syntax_tree
 
 BUNDLED WITH
-   2.7.2
+  4.0.4

lib/saml_authenticator.rb

@@ -18,26 +18,29 @@ def setting(key)
   end
 
   DEFAULT_ATTRIBUTES = {
-    "name" => ["fullName", "name"],
-    "email" => ["email", "mail"],
-    "first_name" => ["first_name", "firstname", "firstName"],
-    "last_name" => ["last_name", "lastname", "lastName"],
+    "name" => %w[fullName name],
+    "email" => %w[email mail],
+    "first_name" => %w[first_name firstname firstName],
+    "last_name" => %w[last_name lastname lastName],
     "nickname" => ["screenName"],
   }
 
   def request_attributes
-    attrs = DEFAULT_ATTRIBUTES.keys | setting(:request_attributes).split("|").compact_blank.map(&:strip)
-    attrs.map { |name| { name: , name_format: attribute_name_format, friendly_name: name } }
+    attrs =
+      DEFAULT_ATTRIBUTES.keys | setting(:request_attributes).split("|").compact_blank.map(&:strip)
+    attrs.map { |name| { name:, name_format: attribute_name_format, friendly_name: name } }
   end
 
   def attribute_statements
     result = Hash.new { |h, k| h[k] = [] }
 
-    setting(:attribute_statements).split("|").each do |statement|
-      attrs = statement.split(":")
-      next if attrs.size != 2 || attrs[0].blank? || attrs[1].blank?
-      result[attrs[0].strip] |= attrs[1].split(",").compact_blank.map(&:strip)
-    end
+    setting(:attribute_statements)
+      .split("|")
+      .each do |statement|
+        attrs = statement.split(":")
+        next if attrs.size != 2 || attrs[0].blank? || attrs[1].blank?
+        result[attrs[0].strip] |= attrs[1].split(",").compact_blank.map(&:strip)
+      end
 
     DEFAULT_ATTRIBUTES.each { |key, defaults| result[key] |= defaults }
 

package.json

@@ -1,17 +1,33 @@
 {
   "private": true,
   "devDependencies": {
-    "@discourse/lint-configs": "2.32.0",
-    "ember-template-lint": "7.9.1",
-    "eslint": "9.37.0",
-    "prettier": "3.6.2",
-    "stylelint": "16.25.0"
+    "@discourse/lint-configs": "2.37.2",
+    "@glint/ember-tsc": "1.0.9",
+    "concurrently": "^9.2.1",
+    "discourse": "npm:@discourse/types@2026.1.0-2709d36",
+    "ember-template-lint": "7.9.3",
+    "eslint": "9.39.2",
+    "prettier": "3.8.0",
+    "stylelint": "17.0.0"
+  },
+  "scripts": {
+    "lint": "concurrently \"pnpm:lint:*(!fix)\" --names \"lint:\"",
+    "lint:fix": "concurrently \"pnpm:lint:*:fix\" --names \"fix:\"",
+    "lint:css": "pnpm stylelint assets/stylesheets/**/*.scss --allow-empty-input",
+    "lint:css:fix": "pnpm stylelint assets/stylesheets/**/*.scss --fix --allow-empty-input",
+    "lint:js": "eslint {assets,admin/assets,test}/javascripts --cache --no-error-on-unmatched-pattern",
+    "lint:js:fix": "eslint {assets,admin/assets,test}/javascripts --fix --no-error-on-unmatched-pattern",
+    "lint:hbs": "ember-template-lint {assets,admin/assets,test}/javascripts/**/*.gjs --no-error-on-unmatched-pattern",
+    "lint:hbs:fix": "ember-template-lint {assets,admin/assets,test}/javascripts/**/*.gjs --fix --no-error-on-unmatched-pattern",
+    "lint:prettier": "pnpm prettier assets/stylesheets/**/*.scss {assets,admin/assets,test}/javascripts/**/*.{js,gjs} --check --no-error-on-unmatched-pattern",
+    "lint:prettier:fix": "pnpm prettier assets/stylesheets/**/*.scss {assets,admin/assets,test}/javascripts/**/*.{js,gjs} -w --no-error-on-unmatched-pattern",
+    "lint:types": "ember-tsc -b"
   },
   "engines": {
     "node": ">= 22",
     "npm": "please-use-pnpm",
     "yarn": "please-use-pnpm",
-    "pnpm": "9.x"
+    "pnpm": "^10"
   },
-  "packageManager": "pnpm@9.15.5"
+  "packageManager": "pnpm@10.28.0"
 }