DEV: Update theme name to Advanced Search Banner #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are moving a simplified version of this into core at discourse/discourse#31516, this component becomes Advanced Search Banner. The core welcome banner will be hidden if this component is installed. This commit also re-enables previously disabled specs that would have failed the core PR.
tgxworld
approved these changes
Mar 17, 2025
martin-brennan
added a commit
to discourse/discourse
that referenced
this pull request
Mar 17, 2025
This is a stripped-back version of the Search Banner component https://meta.discourse.org/t/search-banner/122939, which will be renamed to Advanced Search Banner, see discourse/discourse-search-banner#84. This welcome banner interacts with the header search. When `search_experience` is set to `search_field`, we only show the header search after the welcome banner scrolls out of view, and vice-versa. Only new sites will get this feature turned on by default, existing sites have a migration to disable it. --------- Co-authored-by: Joffrey JAFFEUX <[email protected]> Co-authored-by: Jordan Vidrine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are moving a simplified version of this
into core at discourse/discourse#31516,
this component becomes Advanced Search Banner.
The core welcome banner will be hidden if this
component is installed.
This commit also re-enables previously disabled
specs that would have failed the core PR.