DEV: Update linting (#86)

Author: davidtaylorhq

assets/javascripts/discourse/templates/components/teambuild-choice.hbs

@@ -1,11 +1,11 @@
-<div class="teambuild-choice {{if completed 'completed' 'incomplete'}}">
+<div class="teambuild-choice {{if this.completed 'completed' 'incomplete'}}">
   <div class="controls">
-    {{#if readOnly}}
-      {{#if completed}}
+    {{#if this.readOnly}}
+      {{#if this.completed}}
         {{d-icon "check"}}
       {{/if}}
     {{else}}
-      {{#if completed}}
+      {{#if this.completed}}
         <DButton
           @icon="check"
           @action={{action "undo"}}
@@ -21,5 +21,5 @@
       {{/if}}
     {{/if}}
   </div>
-  <div class="choice-label">{{label}}</div>
+  <div class="choice-label">{{this.label}}</div>
 </div>

assets/javascripts/discourse/templates/components/teambuild-target.hbs

@@ -1,14 +1,14 @@
-<div class="teambuild-target {{if editing 'editing'}}">
+<div class="teambuild-target {{if this.editing 'editing'}}">
   <div class="target-details">
-    {{#if editing}}
+    {{#if this.editing}}
       <div class="fields">
         <div class="target-types">
-          {{#each targetTypes as |type|}}
+          {{#each this.targetTypes as |type|}}
             <label>
               <RadioButton
                 @value={{type.id}}
-                @selection={{buffered.target_type_id}}
-                @onChange={{action (mut buffered.target_type_id) type.id}}
+                @selection={{this.buffered.target_type_id}}
+                @onChange={{action (mut this.buffered.target_type_id) type.id}}
                 class={{type.name}}
               />
               {{i18n (concat "discourse_teambuild.targets.types." type.name)}}
@@ -18,44 +18,44 @@
 
         <div class="target-name">
           <Input
-            @value={{buffered.name}}
+            @value={{this.buffered.name}}
             placeholder={{i18n "discourse_teambuild.targets.name"}}
             autofocus="true"
           />
         </div>
 
-        {{#if needsGroup}}
+        {{#if this.needsGroup}}
           <ComboBox
-            @content={{groups}}
-            @value={{buffered.group_id}}
+            @content={{this.groups}}
+            @value={{this.buffered.group_id}}
             @none="discourse_teambuild.targets.choose_group"
           />
         {{/if}}
       </div>
     {{else}}
       <div class="target-name">
-        {{replace-emoji target.name}}
+        {{replace-emoji this.target.name}}
       </div>
       <div class="target-group-name">
-        {{target.group_name}}
+        {{this.target.group_name}}
       </div>
     {{/if}}
   </div>
   <div class="controls">
-    {{#if canMoveUp}}
-      <DButton @icon="arrow-up" @action={{moveUp}} />
+    {{#if this.canMoveUp}}
+      <DButton @icon="arrow-up" @action={{this.moveUp}} />
     {{/if}}
 
-    {{#if canMoveDown}}
-      <DButton @icon="arrow-down" @action={{moveDown}} />
+    {{#if this.canMoveDown}}
+      <DButton @icon="arrow-down" @action={{this.moveDown}} />
     {{/if}}
 
-    {{#if editing}}
+    {{#if this.editing}}
       <DButton
         @icon="check"
         @title="discourse_teambuild.targets.save"
         @action={{action "save"}}
-        @disabled={{saveDisabled}}
+        @disabled={{this.saveDisabled}}
         class="btn-primary save"
       />
 
@@ -69,7 +69,7 @@
       <DButton
         @icon="pencil-alt"
         @title="discourse_teambuild.targets.edit"
-        @action={{action (mut editSelected) true}}
+        @action={{action (mut this.editSelected) true}}
         class="edit"
       />
 

assets/javascripts/discourse/templates/team-build-index.hbs

@@ -1,4 +1,4 @@
-{{#if scores}}
+{{#if this.scores}}
   <table class="high-scores">
     <thead>
       <tr>
@@ -8,7 +8,7 @@
       </tr>
     </thead>
     <tbody>
-      {{#each scores as |s|}}
+      {{#each this.scores as |s|}}
         <tr class={{if s.me "me"}}>
           <td class="rank">
             {{s.rank}}

assets/javascripts/discourse/templates/team-build-manage.hbs

@@ -1,11 +1,11 @@
 <div class="teambuild-manage">
-  {{#if targets}}
-    {{#each sortedTargets as |target idx|}}
+  {{#if this.targets}}
+    {{#each this.sortedTargets as |target idx|}}
       <TeambuildTarget
         @target={{target}}
-        @groups={{groups}}
+        @groups={{this.groups}}
         @index={{idx}}
-        @length={{sortedTargets.length}}
+        @length={{this.sortedTargets.length}}
         @removeTarget={{action "removeTarget" target}}
         @moveUp={{action "move" idx -1}}
         @moveDown={{action "move" idx 1}}

assets/javascripts/discourse/templates/team-build-progress.hbs

@@ -1,42 +1,42 @@
-{{#if siteSettings.teambuild_description}}
+{{#if this.siteSettings.teambuild_description}}
   <div class="teambuild-description">
-    {{siteSettings.teambuild_description}}
+    {{this.siteSettings.teambuild_description}}
   </div>
 {{/if}}
 
 <div class="completed-score">
-  <div class="username">@{{progress.user.username}}</div>
+  <div class="username">@{{this.progress.user.username}}</div>
   <div class="status">
     {{i18n "discourse_teambuild.progress.completed"}}:
-    {{progress.completed.length}}
+    {{this.progress.completed.length}}
     /
-    {{progress.total}}
+    {{this.progress.total}}
   </div>
 </div>
 
 <div class="all-targets">
-  {{#each progress.teambuild_targets as |target|}}
+  {{#each this.progress.teambuild_targets as |target|}}
     <div class="target-type">
       {{#if target.group_id}}
         <div class="description">{{replace-emoji target.name}}</div>
         <div class="target-choices multi-choice">
           {{#each target.users as |u|}}
             <TeambuildChoice
               @label={{u.username}}
-              @progress={{progress}}
+              @progress={{this.progress}}
               @target={{target}}
               @userId={{u.id}}
-              @readOnly={{readOnly}}
+              @readOnly={{this.readOnly}}
             />
           {{/each}}
         </div>
       {{else}}
         <TeambuildChoice
           @label={{replace-emoji target.name}}
-          @progress={{progress}}
+          @progress={{this.progress}}
           @target={{target}}
-          @userId={{progress.user.id}}
-          @readOnly={{readOnly}}
+          @userId={{this.progress.user.id}}
+          @readOnly={{this.readOnly}}
         />
       {{/if}}
     </div>

assets/javascripts/discourse/templates/team-build.hbs

@@ -1,5 +1,5 @@
 <div class="team-build">
-  <h1>{{siteSettings.teambuild_name}}</h1>
+  <h1>{{this.siteSettings.teambuild_name}}</h1>
 
   <ul class="nav nav-pills">
     <NavItem
@@ -10,7 +10,7 @@
       @route="teamBuild.progress"
       @label="discourse_teambuild.progress.title"
     />
-    {{#if currentUser.staff}}
+    {{#if this.currentUser.staff}}
       <NavItem
         @route="teamBuild.manage"
         @label="discourse_teambuild.manage.title"

package.json

@@ -1,7 +1,7 @@
 {
   "private": true,
   "devDependencies": {
-    "@discourse/lint-configs": "2.0.1",
+    "@discourse/lint-configs": "2.2.1",
     "ember-template-lint": "6.0.0",
     "eslint": "9.14.0",
     "prettier": "2.8.8"