DEV: Add support for glimmer topic list #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaylorhq
force-pushed
the
modernize
branch
3 times, most recently
from
a7f26fd to
a66b7bd
Compare
davidtaylorhq
changed the title
davidtaylorhq
added a commit
to discourse/discourse
that referenced
this pull request
Dec 4, 2024
This makes the theme component compatible with core's glimmer topic list, while maintaining compatibility with the raw-hbs topic list. Some parts of the logic (e.g. the masonry layout system, and the topic-list-before-link outlet) are reimplemented in a way which works in both old and new topic-lists. Other parts are re-implemented separately for the new topic list. For those parts, the legacy versions are isolated in the `topic-thumbnails-init-legacy.js` initializer for future removal.
davidtaylorhq
force-pushed
the
modernize
branch
from
a66b7bd to
705c858
Compare
davidtaylorhq
added a commit
to discourse/discourse
that referenced
this pull request
Dec 4, 2024
davidtaylorhq
added a commit
to discourse/discourse
that referenced
this pull request
Dec 4, 2024
davidtaylorhq
added a commit
to discourse/discourse
that referenced
this pull request
Dec 5, 2024
davidtaylorhq
added a commit
to discourse/discourse
that referenced
this pull request
Dec 6, 2024
CvX
approved these changes
Dec 16, 2024
|
|
||
| const siteSettings = api.container.lookup("service:site-settings"); | ||
| if (settings.docs_thumbnail_mode !== "none" && siteSettings.docs_enabled) { | ||
| api.modifyClass("component:docs-topic-list", { |
Contributor
There was a problem hiding this comment.
do we need to keep it as is or can we update it to the native class syntax?
Member
Author
There was a problem hiding this comment.
We don't currently have any way to control classNameBindings via the native class syntax, so will leave it for now 😬
Co-authored-by: Jarek Radosz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the theme component compatible with core's glimmer topic list, while maintaining compatibility with the raw-hbs topic list.
Some parts of the logic (e.g. the masonry layout system, and the topic-list-before-link outlet) are reimplemented in a way which works in both old and new topic-lists.
Other parts are re-implemented separately for the new topic list. For those parts, the legacy versions are isolated in the
topic-thumbnails-init-legacy.jsinitializer for future removal.Depends on discourse/discourse#30105