Skip to content

DEV: Update specs for core change #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 19, 2024
Merged

DEV: Update specs for core change #61

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b331c1
DEV: Update specs for core change
davidtaylorhq Dec 19, 2024
95f7796
test
davidtaylorhq Dec 19, 2024
5a6e6cf
lint
davidtaylorhq Dec 19, 2024
a617d38
fixup
davidtaylorhq Dec 19, 2024
faa2ed1
Revert "test"
davidtaylorhq Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/discourse-theme.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@ on:
jobs:
ci:
uses: discourse/.github/.github/workflows/discourse-theme.yml@v1
with:
core_ref: glimmer-topic-list-mode
15 changes: 7 additions & 8 deletions spec/system/topic_thumbnails_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,13 @@
end

context "with default raw-hbs topic list" do
before do
SiteSetting.glimmer_topic_list_mode = "disabled"
end

it "is using legacy topic list" do
visit "/latest"
expect(page).to have_css(".topic-list")
enabled =
page.evaluate_script("Discourse.lookup('service:current-user').canUseGlimmerTopicList")
expect(page).to have_css(".topic-list.ember-view")
expect(enabled).to eq(false)
end

Expand All @@ -52,15 +54,12 @@

context "with glimmer topic list" do
before do
SiteSetting.experimental_glimmer_topic_list_groups = Group::AUTO_GROUPS[:everyone].to_s
SiteSetting.glimmer_topic_list_mode = "auto"
end

it "is using glimmer topic list" do
visit "/latest"
expect(page).to have_css(".topic-list")
enabled =
page.evaluate_script("Discourse.lookup('service:current-user').canUseGlimmerTopicList")
expect(enabled).to eq(true)
expect(page).to have_css(".topic-list:not(.ember-view)")
end

it_behaves_like "topic thumbnails"
Expand Down
Loading