Skip to content

Commit 024fc67

Browse files
committed
More test
1 parent 8df7a49 commit 024fc67

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

spec/lib/guardian_extension_spec.rb

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,12 @@
177177
end
178178

179179
describe "when experimental_inline_translation enabled" do
180-
before { SiteSetting.experimental_inline_translation = true }
180+
before do
181+
SiteSetting.experimental_inline_translation = true
182+
183+
SiteSetting.automatic_translation_backfill_maximum_translations_per_hour = 1
184+
SiteSetting.automatic_translation_target_languages = "pt"
185+
end
181186

182187
describe "logged in user" do
183188
it "cannot translate when user is not in restrict_translation_by_group" do
@@ -190,7 +195,7 @@
190195
before { SiteSetting.restrict_translation_by_group = "#{group.id}" }
191196

192197
it "cannot translate when post has translation for user locale" do
193-
post.set_detected_locale("jp")
198+
post.set_detected_locale("ja")
194199
post.set_translation("pt", "Olá, mundo!")
195200

196201
expect(guardian.can_translate?(post)).to eq(false)

spec/serializers/basic_topic_serializer_spec.rb

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@
2020
topic.title = original_title
2121
SiteSetting.experimental_inline_translation = true
2222
I18n.locale = "ja"
23+
24+
SiteSetting.automatic_translation_backfill_maximum_translations_per_hour = 1
25+
SiteSetting.automatic_translation_target_languages = "ja"
2326
end
2427

2528
def serialize_topic(guardian_user: user, params: {})
@@ -53,6 +56,14 @@ def serialize_topic(guardian_user: user, params: {})
5356
expect(serialize_topic.fancy_title).to eq(topic.fancy_title)
5457
end
5558

59+
it "does not replace fancy_title when user's locale is not in target languages" do
60+
I18n.locale = "es"
61+
topic.set_detected_locale("en")
62+
topic.set_translation("es", jap_title)
63+
64+
expect(serialize_topic.fancy_title).to eq(topic.fancy_title)
65+
end
66+
5667
it "returns translated title in fancy_title when translation exists for current locale" do
5768
topic.set_translation("ja", jap_title)
5869
expect(serialize_topic.fancy_title).to eq("<h1>フス・ロ・ダ・ア</h1>")

0 commit comments

Comments
 (0)