Update tests using custom fields

Author: nattsw

db/migrate/20250205082401_move_translations_custom_fields_to_table.rb

@@ -35,6 +35,7 @@ def migrate_custom_fields(model)
           SELECT #{model}_id, value
           FROM #{model}_custom_fields
           WHERE name = 'post_detected_lang'
+          AND length(value) <= 20
           AND id >= :start_id
           AND id < :end_id
           ORDER BY id

spec/fabricators/post_locale.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+Fabricator(:post_locale, from: DiscourseTranslator::PostLocale) do
+  post
+  detected_locale { %w[en de es en-GB ja pt pt-BR].sample }
+end

spec/fabricators/post_translation.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+Fabricator(:post_translation, from: DiscourseTranslator::PostTranslation) do
+  post
+  locale { %w[en de es en-GB ja pt pt-BR].sample }
+  translation do |attrs|
+    {
+      "en" => "Hello",
+      "de" => "Hallo",
+      "es" => "Hola",
+      "en-GB" => "Hello",
+      "ja" => "こんにちは",
+      "pt" => "Olá",
+      "pt-BR" => "Olá",
+    }[
+      attrs[:locale]
+    ]
+  end
+end

spec/jobs/detect_posts_language_spec.rb

@@ -23,7 +23,7 @@
 
     posts.each do |post|
       post.reload
-      expect(post.custom_fields[DiscourseTranslator::DETECTED_LANG_CUSTOM_FIELD]).not_to be_nil
+      expect(post.detected_locale).not_to be_nil
     end
 
     expect(Discourse.redis.smembers(redis_key)).to be_empty

spec/lib/guardian_extension_spec.rb

@@ -156,15 +156,13 @@
             end
 
             it "cannot translate when post has DETECTED_LANG_CUSTOM_FIELD matches locale" do
-              post.custom_fields[DiscourseTranslator::DETECTED_LANG_CUSTOM_FIELD] = "pt"
-              post.save
+              post.set_detected_locale("pt")
 
               expect(guardian.can_translate?(post)).to eq(false)
             end
 
             it "can translate when post has DETECTED_LANG_CUSTOM_FIELD does not match locale" do
-              post.custom_fields[DiscourseTranslator::DETECTED_LANG_CUSTOM_FIELD] = "jp"
-              post.save
+              post.set_detected_locale("jp")
 
               expect(guardian.can_translate?(post)).to eq(true)
             end

spec/models/post_spec.rb

@@ -11,7 +11,7 @@
     it "should reset translation data when post title has been updated" do
       Fabricate(:post_translation, post:)
       Fabricate(:post_locale, post:)
-      post.update!(title: "this is an updated title")
+      post.update!(raw: "this is an updated title")
 
       expect(DiscourseTranslator::PostLocale.where(post:)).to be_empty
       expect(DiscourseTranslator::PostLocale.find_by(post:)).to be_nil

spec/models/translation_tables_spec.rb

@@ -90,7 +90,8 @@ def create_translation_custom_fields(count)
       post.save_custom_fields(true)
 
       migration = described_class.new
-      migration.up
+      expect { migration.up }.not_to raise_error
+
       expect(PostLocale.count).to eq(0)
       expect(PostTranslation.count).to eq(0)
     end

spec/serializers/post_serializer_spec.rb

@@ -63,15 +63,13 @@
             end
 
             it "cannot translate when post has DETECTED_LANG_CUSTOM_FIELD matches locale" do
-              post.custom_fields[DiscourseTranslator::DETECTED_LANG_CUSTOM_FIELD] = "pt"
-              post.save
+              post.set_detected_locale("pt")
 
               expect(serializer.can_translate).to eq(false)
             end
 
             it "can translate when post has DETECTED_LANG_CUSTOM_FIELD does not match locale" do
-              post.custom_fields[DiscourseTranslator::DETECTED_LANG_CUSTOM_FIELD] = "jp"
-              post.save
+              post.set_detected_locale("jp")
 
               expect(serializer.can_translate).to eq(true)
             end

spec/services/amazon_spec.rb

@@ -37,11 +37,7 @@
     it "should store the detected language in a custom field" do
       expect(described_class.detect(post)).to eq(detected_lang)
 
-      2.times do
-        expect(post.custom_fields[::DiscourseTranslator::DETECTED_LANG_CUSTOM_FIELD]).to eq(
-          detected_lang,
-        )
-      end
+      expect(post.detected_locale).to eq(detected_lang)
     end
 
     it "should fail graciously when the cooked translated text is blank" do
@@ -65,8 +61,7 @@
         },
       )
       described_class.stubs(:client).returns(client)
-      post.custom_fields[::DiscourseTranslator::DETECTED_LANG_CUSTOM_FIELD] = "en"
-      post.save_custom_fields
+      post.set_detected_locale("en")
       I18n.stubs(:locale).returns(:es)
     end
 

spec/services/base_spec.rb

@@ -116,7 +116,6 @@ class EmptyTranslator < DiscourseTranslator::Base
     end
 
     it "performs detection if no cached result" do
-      TestTranslator.save_detected_locale(post) { nil }
       TestTranslator.expects(:detect!).with(post).returns("es")
 
       expect(TestTranslator.detect(post)).to eq("es")
@@ -147,15 +146,13 @@ class EmptyTranslator < DiscourseTranslator::Base
 
     it "raises error when translation not supported" do
       TestTranslator.save_detected_locale(post) { "xx" }
-      TestTranslator.save_translation(post) { nil }
       TestTranslator.expects(:translate_supported?).with("xx", :en).returns(false)
 
       expect { TestTranslator.translate(post) }.to raise_error(DiscourseTranslator::TranslatorError)
     end
 
     it "performs translation when needed" do
       TestTranslator.save_detected_locale(post) { "es" }
-      TestTranslator.save_translation(post) { nil }
       TestTranslator.expects(:translate!).returns("hello")
 
       expect(TestTranslator.translate(post)).to eq(%w[es hello])