Do not escape titles as we need to keep compatibility with manual inline translations

Author: nattsw

app/models/concerns/discourse_translator/translatable.rb

@@ -24,7 +24,7 @@ def set_detected_locale(locale)
     # @param text [String] the translated text
     def set_translation(locale, text)
       locale = locale.to_s.gsub("_", "-")
-      text = DiscourseTranslator::TranslatedContentSanitizer.sanitize(self.class, text)
+      text = DiscourseTranslator::TranslatedContentSanitizer.sanitize(text)
       translations.find_or_initialize_by(locale: locale).update!(translation: text)
     end
 

lib/discourse_translator/translated_content_sanitizer.rb

@@ -2,17 +2,8 @@
 
 module DiscourseTranslator
   class TranslatedContentSanitizer
-    def self.sanitize(model, content)
-      case model.to_s
-      when "Topic"
-        return ERB::Util.html_escape(content) unless SiteSetting.title_fancy_entities?
-        Topic.fancy_title(content)
-      when "Post"
-        PrettyText.cleanup(content, {})
-      else
-        # raise an error if the model is not supported
-        raise ArgumentError.new("Model not supported")
-      end
+    def self.sanitize(content)
+      PrettyText.cleanup(content, {})
     end
   end
 end

spec/lib/translated_content_sanitizer_spec.rb

@@ -1,29 +1,12 @@
 # frozen_string_literal: true
 
 describe DiscourseTranslator::TranslatedContentSanitizer do
-  describe "Posts" do
-    it "sanitizes the content" do
-      sanitized =
-        DiscourseTranslator::TranslatedContentSanitizer.sanitize(
-          Post,
-          "<script>alert('test')</script><p> <h1>Testing</h1> This is a test post</p>",
-        )
-
-      expect(sanitized).to eq("<p> </p><h1>Testing</h1> This is a test post<p></p>")
-    end
-  end
-
-  describe "Topics" do
-    it "escapes and prettifies" do
-      sanitized =
-        DiscourseTranslator::TranslatedContentSanitizer.sanitize(
-          Topic,
-          "<script>alert('test')</script><p> <h1>Testing</h1> This is a test post</p>",
-        )
-
-      expect(sanitized).to eq(
-        "&lt;script&gt;alert(&lsquo;test&rsquo;)&lt;/script&gt;&lt;p&gt; &lt;h1&gt;Testing&lt;/h1&gt; This is a test post&lt;/p&gt;",
+  it "sanitizes the content" do
+    sanitized =
+      DiscourseTranslator::TranslatedContentSanitizer.sanitize(
+        "<script>alert('test')</script><p> <h1>Testing</h1> This is a test post</p>",
       )
-    end
+
+    expect(sanitized).to eq("<p> </p><h1>Testing</h1> This is a test post<p></p>")
   end
 end