update job

Author: nattsw

app/jobs/regular/translate_posts.rb

@@ -14,21 +14,24 @@ def execute(args)
       locales = SiteSetting.automatic_translation_target_languages.split("|")
       return if locales.blank?
 
-      # keeping this query simple by just getting any post with a missing localization
-      posts =
-        Post
-          .left_joins(:post_localizations)
-          .where(deleted_at: nil)
-          .where("posts.user_id > 0")
-          .where.not(raw: [nil, ""])
-          .group("posts.id")
-          .having(
-            "COUNT(DISTINCT CASE WHEN post_localizations.locale IN (?) THEN post_localizations.locale END) < ?",
-            locales,
-            locales.size,
+      sql = <<~SQL
+        SELECT DISTINCT posts.*
+        FROM posts
+        CROSS JOIN unnest(ARRAY[#{locales.map { |l| ActiveRecord::Base.connection.quote(l) }.join(",")}]) AS target_locale(locale)
+        WHERE
+          posts.deleted_at IS NULL
+          AND posts.user_id > 0
+          AND posts.raw IS NOT NULL AND posts.raw <> ''
+          AND posts.locale IS NOT NULL
+          AND target_locale.locale != posts.locale
+          AND NOT EXISTS (
+            SELECT 1 FROM post_localizations
+            WHERE post_localizations.post_id = posts.id
+              AND post_localizations.locale = target_locale.locale
           )
-          .order(updated_at: :desc)
-          .limit(BATCH_SIZE)
+      SQL
+
+      posts = Post.find_by_sql(sql)
 
       return if posts.empty?
 

spec/jobs/translate_posts_spec.rb

@@ -4,7 +4,7 @@
   fab!(:post)
   subject(:job) { described_class.new }
 
-  let(:locales) { %w[en ja] }
+  let(:locales) { %w[en ja de] }
 
   before do
     SiteSetting.translator_enabled = true
@@ -41,13 +41,6 @@
     job.execute({})
   end
 
-  it "translates posts to the configured locales" do
-    DiscourseTranslator::PostTranslator.expects(:translate).with(post, "en").at_least_once
-    DiscourseTranslator::PostTranslator.expects(:translate).with(post, "ja").at_least_once
-
-    job.execute({})
-  end
-
   it "skips posts that already have localizations" do
     Post.all.each do |post|
       Fabricate(:post_localization, post:, locale: "en")
@@ -67,19 +60,61 @@
   end
 
   it "handles translation errors gracefully" do
+    post.update(locale: "es")
     DiscourseTranslator::PostTranslator
       .expects(:translate)
       .with(post, "en")
       .raises(StandardError.new("API error"))
     DiscourseTranslator::PostTranslator.expects(:translate).with(post, "ja").once
+    DiscourseTranslator::PostTranslator.expects(:translate).with(post, "de").once
 
     expect { job.execute({}) }.not_to raise_error
   end
 
   it "logs a summary after translation" do
+    post.update(locale: "es")
     DiscourseTranslator::PostTranslator.stubs(:translate)
     DiscourseTranslator::VerboseLogger.expects(:log).with(includes("Translated 1 posts to en, ja"))
 
     job.execute({})
   end
+
+  context "translation scenarios" do
+    it "scenario 1: skips post when locale is not set" do
+      DiscourseTranslator::PostTranslator.expects(:translate).never
+
+      job.execute({})
+    end
+
+    it "scenario 2: returns post with locale 'es' if localizations for en/ja/de do not exist" do
+      post = Fabricate(:post, locale: "es")
+
+      DiscourseTranslator::PostTranslator.expects(:translate).with(post, "en").once
+      DiscourseTranslator::PostTranslator.expects(:translate).with(post, "ja").once
+      DiscourseTranslator::PostTranslator.expects(:translate).with(post, "de").once
+
+      job.execute({})
+    end
+
+    it "scenario 3: returns post with locale 'en' if ja/de localization does not exist" do
+      post = Fabricate(:post, locale: "en")
+
+      DiscourseTranslator::PostTranslator.expects(:translate).with(post, "ja").once
+      DiscourseTranslator::PostTranslator.expects(:translate).with(post, "de").once
+      DiscourseTranslator::PostTranslator.expects(:translate).with(post, "en").never
+
+      job.execute({})
+    end
+
+    it "scenario 4: skips post with locale 'en' if 'ja' localization already exists" do
+      post = Fabricate(:post, locale: "en")
+      Fabricate(:post_localization, post: post, locale: "ja")
+
+      DiscourseTranslator::PostTranslator.expects(:translate).with(post, "en").never
+      DiscourseTranslator::PostTranslator.expects(:translate).with(post, "ja").never
+      DiscourseTranslator::PostTranslator.expects(:translate).with(post, "de").once
+
+      job.execute({})
+    end
+  end
 end