DEV: Move translation custom fields into their own tables

Author: nattsw

app/models/discourse_translator/post_language.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+module DiscourseTranslator
+  class PostLanguage < ActiveRecord::Base
+    self.table_name = "discourse_translator_post_languages"
+
+    belongs_to :post
+
+    validates :post_id, presence: true, uniqueness: true
+    validates :detected_locale, presence: true
+  end
+end

app/models/discourse_translator/post_translation.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module DiscourseTranslator
+  class PostTranslation < ActiveRecord::Base
+    self.table_name = "discourse_translator_post_translations"
+
+    belongs_to :post
+
+    validates :post_id, presence: true
+    validates :locale, presence: true
+    validates :translation, presence: true
+    validates :locale, uniqueness: { scope: :post_id }
+
+    def self.translation_for(post_id, locale)
+      find_by(post_id: post_id, locale: locale)&.translation
+    end
+  end
+end

app/models/discourse_translator/topic_language.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+module DiscourseTranslator
+  class TopicLanguage < ActiveRecord::Base
+    self.table_name = "discourse_translator_topic_languages"
+
+    belongs_to :topic
+
+    validates :topic_id, presence: true, uniqueness: true
+    validates :detected_locale, presence: true
+  end
+end

app/models/discourse_translator/topic_translation.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module DiscourseTranslator
+  class TopicTranslation < ActiveRecord::Base
+    self.table_name = "discourse_translator_topic_translations"
+
+    belongs_to :topic
+
+    validates :topic_id, presence: true
+    validates :locale, presence: true
+    validates :translation, presence: true
+    validates :locale, uniqueness: { scope: :topic_id }
+
+    def self.translation_for(topic_id, locale)
+      find_by(topic_id: topic_id, locale: locale)&.translation
+    end
+  end
+end

spec/models/translation_tables_spec.rb

@@ -0,0 +1,58 @@
+# frozen_string_literal: true
+
+require_relative "../../db/migrate/20210922193500_move_translations_custom_fields_to_table"
+
+RSpec.describe "MoveTranslationsCustomFieldsToTable" do
+  fab!(:topic) { Fabricate(:topic) }
+  fab!(:post) { Fabricate(:post) }
+
+  before do
+    TopicCustomField.create!(topic_id: topic.id, name: "post_detected_lang", value: "en")
+
+    PostCustomField.create!(post_id: post.id, name: "post_detected_lang", value: "es")
+
+    TopicCustomField.create!(
+      topic_id: topic.id,
+      name: "translated_text",
+      value: { fr: "Bonjour", es: "Hola" }.to_json,
+    )
+
+    PostCustomField.create!(
+      post_id: post.id,
+      name: "translated_text",
+      value: { en: "Hello", fr: "Salut" }.to_json,
+    )
+  end
+
+  it "correctly migrates custom fields to new tables" do
+    MoveTranslationsCustomFieldsToTable.new.up
+
+    # Check languages
+    topic_lang = DiscourseTranslatorTopicLanguage.find_by(topic_id: topic.id)
+    expect(topic_lang.detected_locale).to eq("en")
+
+    post_lang = DiscourseTranslatorPostLanguage.find_by(post_id: post.id)
+    expect(post_lang.detected_locale).to eq("es")
+
+    # Check translations
+    topic_translations = DiscourseTranslatorTopicTranslation.where(topic_id: topic.id)
+    expect(topic_translations.count).to eq(2)
+    expect(topic_translations.pluck(:locale)).to contain_exactly("fr", "es")
+    expect(topic_translations.find_by(locale: "fr").translation).to eq("Bonjour")
+
+    post_translations = DiscourseTranslatorPostTranslation.where(post_id: post.id)
+    expect(post_translations.count).to eq(2)
+    expect(post_translations.pluck(:locale)).to contain_exactly("en", "fr")
+    expect(post_translations.find_by(locale: "en").translation).to eq("Hello")
+  end
+
+  it "properly cleans up data on rollback" do
+    MoveTranslationsCustomFieldsToTable.new.up
+    MoveTranslationsCustomFieldsToTable.new.down
+
+    expect(DiscourseTranslatorTopicLanguage.count).to eq(0)
+    expect(DiscourseTranslatorTopicTranslation.count).to eq(0)
+    expect(DiscourseTranslatorPostLanguage.count).to eq(0)
+    expect(DiscourseTranslatorPostTranslation.count).to eq(0)
+  end
+end