DEV: Entirely remove inline translations (#294)

Author: nattsw

assets/javascripts/discourse/components/translated-post.gjs

@@ -31,35 +31,29 @@ export default class TranslatedPost extends Component {
     return this.post.translatedTitle;
   }
 
-  get showTranslation() {
-    return !this.siteSettings.experimental_inline_translation;
-  }
-
   <template>
     <div class="post-translation">
       <ConditionalLoadingSpinner
         class="post-translation"
         @condition={{this.loading}}
         @size="small"
       >
-        {{#if this.showTranslation}}
-          <hr />
-          {{#if this.translatedTitle}}
-            <div class="topic-attribution">
-              {{this.translatedTitle}}
-            </div>
-          {{/if}}
-          <div class="post-attribution">
-            {{i18n
-              "translator.translated_from"
-              language=this.post.detectedLang
-              translator=this.siteSettings.translator_provider
-            }}
-          </div>
-          <div class="cooked">
-            {{htmlSafe this.post.translatedText}}
+        <hr />
+        {{#if this.translatedTitle}}
+          <div class="topic-attribution">
+            {{this.translatedTitle}}
           </div>
         {{/if}}
+        <div class="post-attribution">
+          {{i18n
+            "translator.translated_from"
+            language=this.post.detectedLang
+            translator=this.siteSettings.translator_provider
+          }}
+        </div>
+        <div class="cooked">
+          {{htmlSafe this.post.translatedText}}
+        </div>
       </ConditionalLoadingSpinner>
     </div>
   </template>

assets/javascripts/discourse/initializers/extend-for-translate-button.js

@@ -26,42 +26,6 @@ function initializeTranslation(api) {
     );
   }
 
-  if (
-    siteSettings.experimental_inline_translation &&
-    (currentUser || siteSettings.experimental_anon_language_switcher)
-  ) {
-    api.renderInOutlet("topic-navigation", ShowOriginalContent);
-
-    api.registerCustomPostMessageCallback(
-      "translated_post",
-      (topicController, data) => {
-        if (
-          new URLSearchParams(window.location.search).get("show") === "original"
-        ) {
-          return;
-        }
-        const postStream = topicController.get("model.postStream");
-        postStream.triggerChangedPost(data.id, data.updated_at).then(() => {
-          topicController.appEvents.trigger("post-stream:refresh", {
-            id: data.id,
-          });
-        });
-      }
-    );
-
-    api.includePostAttributes("is_translated", "detected_language");
-    api.decorateWidget("post-date:before", (dec) => {
-      if (dec.attrs.is_translated && dec.attrs.detected_language) {
-        return new RenderGlimmer(
-          dec.widget,
-          "div.post-info.post-translated-indicator",
-          TranslatedPostIndicator,
-          { detectedLanguage: dec.attrs.detected_language }
-        );
-      }
-    });
-  }
-
   customizePostMenu(api);
 }
 

assets/javascripts/discourse/services/translator.js

@@ -15,16 +15,6 @@ export default class TranslatorService extends Service {
     post.detectedLang = response.detected_lang;
     post.translatedText = response.translation;
     post.translatedTitle = response.title_translation;
-    if (this.siteSettings.experimental_inline_translation) {
-      if (post.post_number === 1) {
-        post.topic.set("fancy_title", response.title_translation);
-        this.appEvents.trigger("header:update-topic", post.topic);
-        this.documentTitle.setTitle(response.title_translation);
-      }
-      post.set("cooked", response.translation);
-      post.set("can_translate", false);
-      this.appEvents.trigger("post-stream:refresh", { id: post.id });
-    }
   }
 
   clearPostTranslation(post) {

config/locales/server.en.yml

@@ -21,7 +21,6 @@ en:
     errors:
       needs_nonzero_backfill: "Automatic language translation requires the 'automatic_translation_backfill_rate' hidden setting to be a non-zero value. Please approach your site administrator to increase this limit."
       experimental_anon_language_switcher_requirements: "The experimental language switcher requires the `set locale from cookie` site setting to be enabled, and the `automatic translation target languages` to have at least one language."
-    experimental_inline_translation: "Enable experimental inline translation feature. This replaces existing parallel translation, allowing site visitors with a non-default locale to view content in their language."
     automatic_translation_target_languages: "The languages to automatically translate user content (posts, topics) to. If empty, no languages will be automatically translated."
   translator:
     failed:

config/settings.yml

@@ -126,9 +126,6 @@ discourse_translator:
     default: false
     client: true
     validator: "DiscourseTranslator::Validators::LanguageSwitcherSettingValidator"
-  experimental_inline_translation:
-    default: false
-    client: true
   experimental_content_translation:
     default: false
     hidden: true

lib/discourse_translator/extensions/guardian_extension.rb

@@ -31,14 +31,9 @@ def can_translate?(post)
         # this prevents the 🌐from appearing and then disappearing if the lang is same as user's lang
         return false if post.updated_at > POST_DETECTION_BUFFER.ago && post.detected_locale.blank?
 
-        if SiteSetting.experimental_inline_translation
-          locale = DiscourseTranslator::InlineTranslation.effective_locale
-          return false if post.locale_matches?(locale)
-          post.translation_for(locale).nil?
-        else
-          return false if post.locale_matches?(I18n.locale)
-          poster_group_allow_translate?(post)
-        end
+        locale = I18n.locale
+        return false if post.locale_matches?(locale)
+        poster_group_allow_translate?(post)
       end
     end
   end