Lint

Author: nattsw

spec/lib/translator_selection_validator_spec.rb

@@ -3,30 +3,28 @@
 require "rails_helper"
 
 describe ::DiscourseTranslator::TranslatorSelectionValidator do
-  subject { described_class.new }
-
-  fab!(:llm_model) { Fabricate(:llm_model) }
+  fab!(:llm_model)
 
   describe "#valid_value?" do
     context "when value is blank" do
       it "returns true" do
-        expect(subject.valid_value?(nil)).to eq(true)
-        expect(subject.valid_value?("")).to eq(true)
+        expect(described_class.new.valid_value?(nil)).to eq(true)
+        expect(described_class.new.valid_value?("")).to eq(true)
       end
     end
 
     context "when value is 'DiscourseAi'" do
       context "when DiscourseAutomation is not defined" do
         it "returns false" do
           hide_const("DiscourseAutomation")
-          expect(subject.valid_value?("DiscourseAi")).to eq(false)
+          expect(described_class.new.valid_value?("DiscourseAi")).to eq(false)
         end
       end
 
       context "when DiscourseAutomation is defined but ai_helper_enabled is false" do
         it "returns false" do
           SiteSetting.ai_helper_enabled = false
-          expect(subject.valid_value?("DiscourseAi")).to eq(false)
+          expect(described_class.new.valid_value?("DiscourseAi")).to eq(false)
         end
       end
 
@@ -36,15 +34,15 @@
             SiteSetting.ai_helper_model = "custom:#{llm_model.id}"
             SiteSetting.ai_helper_enabled = true
           end
-          expect(subject.valid_value?("DiscourseAi")).to eq(true)
+          expect(described_class.new.valid_value?("DiscourseAi")).to eq(true)
         end
       end
     end
 
     context "when value is not 'DiscourseAi'" do
       it "returns true" do
-        expect(subject.valid_value?("googly")).to eq(true)
-        expect(subject.valid_value?("poopy")).to eq(true)
+        expect(described_class.new.valid_value?("googly")).to eq(true)
+        expect(described_class.new.valid_value?("poopy")).to eq(true)
       end
     end
   end
@@ -53,14 +51,18 @@
     context "when DiscourseAutomation is not defined" do
       it "returns the not_installed error message" do
         hide_const("DiscourseAutomation")
-        expect(subject.error_message).to eq(I18n.t("translator.discourse_ai.not_installed"))
+        expect(described_class.new.error_message).to eq(
+          I18n.t("translator.discourse_ai.not_installed"),
+        )
       end
     end
 
     context "when DiscourseAutomation is defined but ai_helper_enabled is false" do
       it "returns the ai_helper_required error message" do
         SiteSetting.ai_helper_enabled = false
-        expect(subject.error_message).to eq(I18n.t("translator.discourse_ai.ai_helper_required"))
+        expect(described_class.new.error_message).to eq(
+          I18n.t("translator.discourse_ai.ai_helper_required"),
+        )
       end
     end
 
@@ -70,7 +72,7 @@
           SiteSetting.ai_helper_model = "custom:#{llm_model.id}"
           SiteSetting.ai_helper_enabled = true
         end
-        expect(subject.error_message).to be_nil
+        expect(described_class.new.error_message).to be_nil
       end
     end
   end

spec/services/discourse_ai_spec.rb

@@ -23,29 +23,31 @@
     end
 
     it "truncates to MAX LENGTH" do
-      truncated_text = post.cooked.truncate(DiscourseTranslator::DiscourseAi::MAX_DETECT_LOCALE_TEXT_LENGTH)
-      expect_any_instance_of(::DiscourseAi::AiHelper::Assistant)
-        .to receive(:generate_and_send_prompt)
-              .with(
-                CompletionPrompt.find_by(id: CompletionPrompt::DETECT_TEXT_LOCALE),
-                truncated_text,
-                Discourse.system_user
-              ).and_call_original
+      truncated_text =
+        post.cooked.truncate(DiscourseTranslator::DiscourseAi::MAX_DETECT_LOCALE_TEXT_LENGTH)
+      expect_any_instance_of(::DiscourseAi::AiHelper::Assistant).to receive(
+        :generate_and_send_prompt,
+      ).with(
+        CompletionPrompt.find_by(id: CompletionPrompt::DETECT_TEXT_LOCALE),
+        truncated_text,
+        Discourse.system_user,
+      ).and_call_original
 
       DiscourseAi::Completions::Llm.with_prepared_responses(["<output>de</output>"]) do
         DiscourseTranslator::DiscourseAi.detect(post)
       end
     end
 
     it "returns if settings are not correct" do
-
     end
   end
 
   describe ".translate" do
     it "translates the post and returns [locale, translated_text]" do
       post = Fabricate(:post)
-      DiscourseAi::Completions::Llm.with_prepared_responses(["<output>some translated text</output>", "<output>translated</output>"]) do
+      DiscourseAi::Completions::Llm.with_prepared_responses(
+        ["<output>some translated text</output>", "<output>translated</output>"],
+      ) do
         locale, translated_text = DiscourseTranslator::DiscourseAi.translate(post)
         expect(locale).to eq "de"
         expect(translated_text).to eq "some translated text"