Remove all traces of CUSTOM_FIELD except in the migration spec

Author: nattsw

plugin.rb

@@ -16,8 +16,6 @@
 module ::DiscourseTranslator
   PLUGIN_NAME = "discourse-translator".freeze
 
-  DETECTED_LANG_CUSTOM_FIELD = "post_detected_lang".freeze
-  TRANSLATED_CUSTOM_FIELD = "translated_text".freeze
   LANG_DETECT_NEEDED = "lang_detect_needed".freeze
 end
 

spec/jobs/detect_posts_language_spec.rb

@@ -35,7 +35,7 @@
 
     posts.each do |post|
       post.reload
-      expect(post.custom_fields[DiscourseTranslator::DETECTED_LANG_CUSTOM_FIELD]).to be_nil
+      expect(post.detected_locale).to be_nil
     end
 
     expect(Discourse.redis.smembers(redis_key)).to match_array(posts.map(&:id).map(&:to_s))

spec/lib/guardian_extension_spec.rb

@@ -151,17 +151,18 @@
           describe "locale is :xx" do
             before { I18n.stubs(:locale).returns(:pt) }
 
-            it "cannot translate when post does not have DETECTED_LANG_CUSTOM_FIELD" do
+            it "cannot translate when post does not have detected locale" do
+              expect(post.detected_locale).to eq(nil)
               expect(guardian.can_translate?(post)).to eq(false)
             end
 
-            it "cannot translate when post has DETECTED_LANG_CUSTOM_FIELD matches locale" do
+            it "cannot translate when post detected locale matches i18n locale" do
               post.set_detected_locale("pt")
 
               expect(guardian.can_translate?(post)).to eq(false)
             end
 
-            it "can translate when post has DETECTED_LANG_CUSTOM_FIELD does not match locale" do
+            it "can translate when post detected locale does not match i18n locale" do
               post.set_detected_locale("jp")
 
               expect(guardian.can_translate?(post)).to eq(true)

spec/models/translation_tables_spec.rb

@@ -4,6 +4,9 @@
 
 module DiscourseTranslator
   describe MoveTranslationsCustomFieldsToTable do
+    DETECTED_LANG_CUSTOM_FIELD = "post_detected_lang".freeze
+    TRANSLATED_CUSTOM_FIELD = "translated_text".freeze
+
     let!(:batch_size) { 3 }
 
     before { described_class.const_set(:BATCH_SIZE, batch_size) }

spec/serializers/post_serializer_spec.rb

@@ -58,17 +58,18 @@
               I18n.stubs(:locale).returns(:pt)
             end
 
-            it "cannot translate when post does not have DETECTED_LANG_CUSTOM_FIELD" do
+            it "cannot translate when post does not have detected locale" do
+              expect(post.detected_locale).to eq(nil)
               expect(serializer.can_translate).to eq(false)
             end
 
-            it "cannot translate when post has DETECTED_LANG_CUSTOM_FIELD matches locale" do
+            it "cannot translate when post detected locale matches i18n locale" do
               post.set_detected_locale("pt")
 
               expect(serializer.can_translate).to eq(false)
             end
 
-            it "can translate when post has DETECTED_LANG_CUSTOM_FIELD does not match locale" do
+            it "can translate when post detected locale does not match i18n locale" do
               post.set_detected_locale("jp")
 
               expect(serializer.can_translate).to eq(true)