DEV: Cleanup terms (#232)

Doing some cleanup
- `experimental_topic_translation` becomes `experimental_inline_translation`
- `translator` becomes `translator_provider`
- DualText translation is now Parallel Translation (the feature where translation is appended to the post, rather than shown inline)
- Unused `translate_posts_to_languages` removed

Author: nattsw

app/controllers/discourse_translator/translator_controller.rb

@@ -41,10 +41,12 @@ def translate
       begin
         title_json = {}
         detected_lang, translation =
-          "DiscourseTranslator::#{SiteSetting.translator}".constantize.translate(post)
+          "DiscourseTranslator::#{SiteSetting.translator_provider}".constantize.translate(post)
         if post.is_first_post?
           _, title_translation =
-            "DiscourseTranslator::#{SiteSetting.translator}".constantize.translate(post.topic)
+            "DiscourseTranslator::#{SiteSetting.translator_provider}".constantize.translate(
+              post.topic,
+            )
           title_json = { title_translation: title_translation }
         end
         render json: { translation: translation, detected_lang: detected_lang }.merge(title_json),

app/jobs/regular/detect_translatable_language.rb

@@ -11,7 +11,7 @@ def execute(args)
       translatable = args[:type].constantize.find_by(id: args[:translatable_id])
       return if translatable.blank?
       begin
-        translator = "DiscourseTranslator::#{SiteSetting.translator}".constantize
+        translator = "DiscourseTranslator::#{SiteSetting.translator_provider}".constantize
         translator.detect(translatable)
       rescue ::DiscourseTranslator::ProblemCheckedTranslationError
         # problem-checked translation errors gracefully

app/jobs/regular/translate_translatable.rb

@@ -11,7 +11,7 @@ def execute(args)
 
       target_locales = SiteSetting.automatic_translation_target_languages.split("|")
       target_locales.each do |target_locale|
-        "DiscourseTranslator::#{SiteSetting.translator}".constantize.translate(
+        "DiscourseTranslator::#{SiteSetting.translator_provider}".constantize.translate(
           translatable,
           target_locale.to_sym,
         )

app/jobs/scheduled/automatic_translation_backfill.rb

@@ -77,7 +77,7 @@ def backfill_locales
     end
 
     def translator
-      @translator_klass ||= "DiscourseTranslator::#{SiteSetting.translator}".constantize
+      @translator_klass ||= "DiscourseTranslator::#{SiteSetting.translator_provider}".constantize
     end
 
     def translate_records(type, record_ids)

app/services/discourse_translator/discourse_ai.rb

@@ -32,7 +32,7 @@ def self.translate!(translatable, target_locale_sym = I18n.locale)
     private
 
     def self.required_settings_enabled
-      SiteSetting.translator_enabled && SiteSetting.translator == "DiscourseAi" &&
+      SiteSetting.translator_enabled && SiteSetting.translator_provider == "DiscourseAi" &&
         SiteSetting.discourse_ai_enabled && SiteSetting.ai_helper_enabled
     end
   end

app/services/problem_check/missing_translator_api_key.rb

@@ -16,14 +16,14 @@ def call
 
   def translation_data
     {
-      provider: SiteSetting.translator,
+      provider: SiteSetting.translator_provider,
       key: I18n.t("site_settings.#{api_key_site_setting_name}"),
       key_name: api_key_site_setting_name,
     }
   end
 
   def api_key_site_setting_name
-    case SiteSetting.translator
+    case SiteSetting.translator_provider
     when "Google"
       "translator_google_api_key"
     when "Microsoft"

assets/javascripts/discourse/components/translated-post.gjs

@@ -32,7 +32,7 @@ export default class TranslatedPost extends Component {
   }
 
   get showTranslation() {
-    return !this.siteSettings.experimental_topic_translation;
+    return !this.siteSettings.experimental_inline_translation;
   }
 
   <template>
@@ -53,7 +53,7 @@ export default class TranslatedPost extends Component {
             {{i18n
               "translator.translated_from"
               language=this.post.detectedLang
-              translator=this.siteSettings.translator
+              translator=this.siteSettings.translator_provider
             }}
           </div>
           <div class="cooked">

assets/javascripts/discourse/initializers/extend-for-translate-button.js

@@ -25,7 +25,7 @@ function initializeTranslation(api) {
   }
 
   if (
-    siteSettings.experimental_topic_translation &&
+    siteSettings.experimental_inline_translation &&
     (currentUser || siteSettings.experimental_anon_language_switcher)
   ) {
     api.renderInOutlet("topic-navigation", ShowOriginalContent);
@@ -83,7 +83,7 @@ function customizeWidgetPostMenu(api) {
     }
 
     const language = dec.attrs.detected_lang;
-    const translator = siteSettings.translator;
+    const translator = siteSettings.translator_provider;
 
     let titleElements = [];
 

assets/javascripts/discourse/services/translator.js

@@ -15,7 +15,7 @@ export default class TranslatorService extends Service {
     post.detectedLang = response.detected_lang;
     post.translatedText = response.translation;
     post.translatedTitle = response.title_translation;
-    if (this.siteSettings.experimental_topic_translation) {
+    if (this.siteSettings.experimental_inline_translation) {
       if (post.post_number === 1) {
         post.topic.set("fancy_title", response.title_translation);
         this.appEvents.trigger("header:update-topic", post.topic);

config/locales/server.ar.yml

@@ -7,7 +7,7 @@
 ar:
   site_settings:
     translator_enabled: "السماح بالترجمة المضمَّنة للمنشورات."
-    translator: "مقدِّم خدمة الترجمة."
+    translator_provider: "مقدِّم خدمة الترجمة."
     translator_azure_subscription_key: "مفتاح اشتراك Azure"
     translator_azure_region: "منطقة Azure"
     translator_google_api_key: "مفتاح واجهة برمجة تطبيقات Google"