Skip to content

Commit bf1ea12

Browse files
authored
DEV: Update linting (#328)
1 parent bdecaa2 commit bf1ea12

File tree

9 files changed

+569
-1022
lines changed

9 files changed

+569
-1022
lines changed

Gemfile.lock

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
GEM
22
remote: https://rubygems.org/
33
specs:
4-
activesupport (8.0.2)
4+
activesupport (8.0.3)
55
base64
66
benchmark (>= 0.3)
77
bigdecimal
@@ -15,47 +15,47 @@ GEM
1515
tzinfo (~> 2.0, >= 2.0.5)
1616
uri (>= 0.13.1)
1717
ast (2.4.3)
18-
base64 (0.2.0)
19-
benchmark (0.4.0)
20-
bigdecimal (3.1.9)
18+
base64 (0.3.0)
19+
benchmark (0.4.1)
20+
bigdecimal (3.3.0)
2121
concurrent-ruby (1.3.5)
22-
connection_pool (2.5.3)
22+
connection_pool (2.5.4)
2323
drb (2.2.3)
2424
i18n (1.14.7)
2525
concurrent-ruby (~> 1.0)
26-
json (2.12.2)
26+
json (2.15.1)
2727
language_server-protocol (3.17.0.5)
2828
lint_roller (1.1.0)
2929
logger (1.7.0)
30-
minitest (5.25.5)
30+
minitest (5.26.0)
3131
parallel (1.27.0)
32-
parser (3.3.8.0)
32+
parser (3.3.9.0)
3333
ast (~> 2.4.1)
3434
racc
3535
prettier_print (1.2.1)
36-
prism (1.4.0)
36+
prism (1.5.1)
3737
racc (1.8.1)
38-
rack (3.1.16)
38+
rack (3.2.2)
3939
rainbow (3.1.1)
40-
regexp_parser (2.10.0)
41-
rubocop (1.75.7)
40+
regexp_parser (2.11.3)
41+
rubocop (1.81.1)
4242
json (~> 2.3)
4343
language_server-protocol (~> 3.17.0.2)
4444
lint_roller (~> 1.1.0)
4545
parallel (~> 1.10)
4646
parser (>= 3.3.0.2)
4747
rainbow (>= 2.2.2, < 4.0)
4848
regexp_parser (>= 2.9.3, < 3.0)
49-
rubocop-ast (>= 1.44.0, < 2.0)
49+
rubocop-ast (>= 1.47.1, < 2.0)
5050
ruby-progressbar (~> 1.7)
5151
unicode-display_width (>= 2.4.0, < 4.0)
52-
rubocop-ast (1.44.1)
52+
rubocop-ast (1.47.1)
5353
parser (>= 3.3.7.2)
5454
prism (~> 1.4)
5555
rubocop-capybara (2.22.1)
5656
lint_roller (~> 1.1)
5757
rubocop (~> 1.72, >= 1.72.1)
58-
rubocop-discourse (3.12.1)
58+
rubocop-discourse (3.13.3)
5959
activesupport (>= 6.1)
6060
lint_roller (>= 1.1.0)
6161
rubocop (>= 1.73.2)
@@ -67,13 +67,13 @@ GEM
6767
rubocop-factory_bot (2.27.1)
6868
lint_roller (~> 1.1)
6969
rubocop (~> 1.72, >= 1.72.1)
70-
rubocop-rails (2.32.0)
70+
rubocop-rails (2.33.4)
7171
activesupport (>= 4.2.0)
7272
lint_roller (~> 1.1)
7373
rack (>= 1.1)
7474
rubocop (>= 1.75.0, < 2.0)
7575
rubocop-ast (>= 1.44.0, < 2.0)
76-
rubocop-rspec (3.6.0)
76+
rubocop-rspec (3.7.0)
7777
lint_roller (~> 1.1)
7878
rubocop (~> 1.72, >= 1.72.1)
7979
rubocop-rspec_rails (2.31.0)
@@ -82,14 +82,14 @@ GEM
8282
rubocop-rspec (~> 3.5)
8383
ruby-progressbar (1.13.0)
8484
securerandom (0.4.1)
85-
syntax_tree (6.2.0)
85+
syntax_tree (6.3.0)
8686
prettier_print (>= 1.2.0)
8787
tzinfo (2.0.6)
8888
concurrent-ruby (~> 1.0)
89-
unicode-display_width (3.1.4)
90-
unicode-emoji (~> 4.0, >= 4.0.4)
91-
unicode-emoji (4.0.4)
92-
uri (1.0.3)
89+
unicode-display_width (3.2.0)
90+
unicode-emoji (~> 4.1)
91+
unicode-emoji (4.1.0)
92+
uri (1.0.4)
9393

9494
PLATFORMS
9595
ruby
@@ -99,4 +99,4 @@ DEPENDENCIES
9999
syntax_tree
100100

101101
BUNDLED WITH
102-
2.6.9
102+
2.7.2

app/controllers/discourse_translator/translator_controller.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def translate
4848
title_json = { title_translation: title_translation }
4949
end
5050
render json: { translation: translation, detected_lang: detected_lang }.merge(title_json),
51-
status: 200
51+
status: :ok
5252
rescue ::DiscourseTranslator::Provider::TranslatorError => e
5353
render_json_error e.message, status: 422
5454
end

assets/javascripts/discourse/components/post-menu/toggle-translation-button.gjs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ export default class ToggleTranslationButton extends Component {
1010
return args.post.can_translate;
1111
}
1212

13-
@service modal;
1413
@service translator;
1514

1615
get isTranslating() {

assets/javascripts/discourse/initializers/extend-for-translate-button.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,6 @@ function customizePostMenu(api) {
3535
export default {
3636
name: "extend-for-translate-button",
3737
initialize() {
38-
withPluginApi("1.39.2", (api) => initializeTranslation(api));
38+
withPluginApi((api) => initializeTranslation(api));
3939
},
4040
};

assets/javascripts/discourse/services/translator.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
1-
import Service, { service } from "@ember/service";
1+
import Service from "@ember/service";
22
import { ajax } from "discourse/lib/ajax";
33

44
export default class TranslatorService extends Service {
5-
@service siteSettings;
6-
@service appEvents;
7-
@service documentTitle;
8-
95
async translatePost(post) {
106
const response = await ajax("/translator/translate", {
117
type: "POST",

package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{
22
"private": true,
33
"devDependencies": {
4-
"@discourse/lint-configs": "2.20.0",
5-
"ember-template-lint": "7.7.0",
6-
"eslint": "9.27.0",
7-
"prettier": "3.5.3",
8-
"stylelint": "16.19.1"
4+
"@discourse/lint-configs": "2.32.0",
5+
"ember-template-lint": "7.9.1",
6+
"eslint": "9.37.0",
7+
"prettier": "3.6.2",
8+
"stylelint": "16.25.0"
99
},
1010
"engines": {
1111
"node": ">= 22",

0 commit comments

Comments
 (0)