FIX: Set a stripped post's locale to site default locale

Author: nattsw

app/services/discourse_translator/base.rb

@@ -88,7 +88,9 @@ def self.get_detected_locale(translatable)
     end
 
     def self.save_detected_locale(translatable)
-      detected_locale = yield
+      # sometimes we may have a user post that is just an emoji
+      # in that case, we will just indicate the post is in the default locale
+      detected_locale = yield.presence || SiteSetting.default_locale
       translatable.set_detected_locale(detected_locale)
 
       detected_locale

spec/services/base_spec.rb

@@ -115,6 +115,14 @@ class EmptyTranslator < DiscourseTranslator::Base
       expect(TestTranslator.detect(post)).to eq("en")
     end
 
+    it "saves the site default locale when detection is empty" do
+      SiteSetting.default_locale = "ja"
+
+      TestTranslator.save_detected_locale(post) { "" }
+
+      expect(post.detected_locale).to eq("ja")
+    end
+
     it "performs detection if no cached result" do
       TestTranslator.expects(:detect!).with(post).returns("es")