FIX: Strip detection text before truncation

Author: nattsw

app/services/discourse_translator/base.rb

@@ -79,8 +79,9 @@ def self.strip_tags_for_detection(detection_text)
     end
 
     def self.text_for_detection(topic_or_post)
-      strip_tags_for_detection(
-        get_text(topic_or_post).truncate(DETECTION_CHAR_LIMIT, omission: nil),
+      strip_tags_for_detection(get_text(topic_or_post)).truncate(
+        DETECTION_CHAR_LIMIT,
+        omission: nil,
       )
     end
 

spec/services/base_spec.rb

@@ -82,6 +82,11 @@ class EmptyTranslator < DiscourseTranslator::Base
       post.cooked = text
       expect(DiscourseTranslator::Base.text_for_detection(post)).to eq(text)
     end
+
+    it "strips text before truncation" do
+      post.cooked = "<img src='http://example.com/image.png' />" + "a" * 1000
+      expect(DiscourseTranslator::Base.text_for_detection(post)).to eq("a" * 1000)
+    end
   end
 
   describe ".text_for_translation" do