FIX: Strips img tags (emojis) when detecting language #182
+38
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because in a text with many emojis, the detected language will unfortunately always be 'en'
nattsw
commented
Nov 27, 2024
Comment on lines
+66
to
+67
| html_doc.css("img").remove | ||
| html_doc.to_html |
Contributor
Author
There was a problem hiding this comment.
This needs to be separate lines 😅
CvX
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because in a text with many emojis, the detected language will unfortunately always be 'en'. Example text:
This PR strips img tags before detecting language. The img tags will be present for translation.
Additional context
In Google Translate API, they actually do provide a way to skip certain tags but only when using the /translate endpoint, not the detect endpoint.
The method would be to add the
translate="no"attribute to the respective html tags. This is also the same for Microsoft Azure and Amazon. But unfortunately this only works for /translate.