FEATURE: Add max character for translation setting #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmusaraj
approved these changes
Nov 27, 2024
| default: '' | ||
| translator_libretranslate_api_key: | ||
| default: '' | ||
| max_characters_per_translation: |
Contributor
There was a problem hiding this comment.
Does this need a description in server.en.yml?
Contributor
Author
There was a problem hiding this comment.
Yeah, I should for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When translating a post, most of our available providers have an arbitrary character limit. In Google, this arbitrary limit is 5000 characters.
This PR removes the arbitrary limits per provider by moving it to a site setting
max_characters_per_translation, and leaves the hard limits set by each provider (Amazon 10k, Azure 50k).Additional context
I bumped the site setting to 10k to test on googleapis, and Google happily translated more than 5k characters despite the recommendation.