FEATURE: Experimental feature for viewing translated topics #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const translatedCooked = helper.getModel().get("translated_cooked"); | ||
| if (translatedCooked) { | ||
| cookedElement.innerHTML = translatedCooked; | ||
| } else { |
There was a problem hiding this comment.
I'm more familiar with ruby so I genuinely am not sure, but in this case do we even want the else for now?
Contributor
Author
There was a problem hiding this comment.
Yeah, it's just a note to indicate it's a missing feature. Should not cost much.
jbrw
approved these changes
Feb 11, 2025
Contributor
Author
|
Thank you @jbrw. |
nattsw
added a commit
that referenced
this pull request
Feb 14, 2025
…slation values (#210) In #205, we returned translated values using existing JS apis. While this was convenient, it does not allow us to modify crawler views such as ... https://github.com/discourse/discourse/blob/main/app/views/topics/show.html.erb ... when we want to serve translated pages. This commit makes use of discourse/discourse#31261 to override the values.
nattsw
added a commit
to discourse/discourse
that referenced
this pull request
May 15, 2025
Related: - discourse/discourse-translator#205 - discourse/discourse-translator#274 - discourse/discourse-translator#294 With this PR, we will start showing localized posts (if available) based on the user's locale. This work had been done in discourse-translator, but is now moving to core.
nattsw
added a commit
to discourse/discourse
that referenced
this pull request
May 26, 2025
In #32618, the button was added to a place which does not show up on mobile. When the feature was still in discourse-translator (discourse/discourse-translator#205), it was added to the plugin outlet which would allow it to show up on both mobile and desktop. This commit moves the button to be a neighbour of the plugin outlet.
martin-brennan
pushed a commit
to discourse/discourse
that referenced
this pull request
Jun 10, 2025
Related: - discourse/discourse-translator#205 - discourse/discourse-translator#274 - discourse/discourse-translator#294 With this PR, we will start showing localized posts (if available) based on the user's locale. This work had been done in discourse-translator, but is now moving to core.
martin-brennan
pushed a commit
to discourse/discourse
that referenced
this pull request
Jun 10, 2025
In #32618, the button was added to a place which does not show up on mobile. When the feature was still in discourse-translator (discourse/discourse-translator#205), it was added to the plugin outlet which would allow it to show up on both mobile and desktop. This commit moves the button to be a neighbour of the plugin outlet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature shows a fully translated topic in the user's language. For now, the topic needs to already have translations for the translated topic to show. If there are posts that have not been translated, the original content will be shown.
Topic fully translated to site locale:
Topic fully translated to lang param:
Show original content of topic
The
translated_titleis returned via theTopicViewSerializerand displayed via theapplyTransformationsAPI.The
translated_cookedis returned via thePostSerializerand displayed viadecorateCooked.This takes a different approach from the previous PR #199 which overrode the
fancy_titleandcookeddirectly.