diff --git a/app/jobs/regular/translate_categories.rb b/app/jobs/regular/translate_categories.rb index ca008ae6..8449b57f 100644 --- a/app/jobs/regular/translate_categories.rb +++ b/app/jobs/regular/translate_categories.rb @@ -7,7 +7,7 @@ class TranslateCategories < ::Jobs::Base def execute(args) return unless SiteSetting.translator_enabled - return unless SiteSetting.experimental_category_translation + return unless SiteSetting.experimental_content_translation locales = SiteSetting.automatic_translation_target_languages.split("|") return if locales.blank? diff --git a/app/jobs/scheduled/automatic_category_translation.rb b/app/jobs/scheduled/automatic_category_translation.rb index ef28e479..c0841577 100644 --- a/app/jobs/scheduled/automatic_category_translation.rb +++ b/app/jobs/scheduled/automatic_category_translation.rb @@ -7,7 +7,7 @@ class AutomaticCategoryTranslation < ::Jobs::Scheduled def execute(args) return unless SiteSetting.translator_enabled - return unless SiteSetting.experimental_category_translation + return unless SiteSetting.experimental_content_translation locales = SiteSetting.automatic_translation_target_languages.split("|") return if locales.blank? diff --git a/app/services/discourse_translator/provider/base_provider.rb b/app/services/discourse_translator/provider/base_provider.rb index a8c8ea89..de44cc79 100644 --- a/app/services/discourse_translator/provider/base_provider.rb +++ b/app/services/discourse_translator/provider/base_provider.rb @@ -65,7 +65,7 @@ def self.translate_translatable!(translatable, target_locale_sym = I18n.locale) raise "Not Implemented" end - def self.translate_text(text, target_locale_sym = I18n.locale) + def self.translate_text!(text, target_locale_sym = I18n.locale) raise "Not Implemented" end diff --git a/config/settings.yml b/config/settings.yml index e293e9ef..4cf99732 100644 --- a/config/settings.yml +++ b/config/settings.yml @@ -129,7 +129,7 @@ discourse_translator: experimental_inline_translation: default: false client: true - experimental_category_translation: + experimental_content_translation: default: false hidden: true discourse_translator_verbose_logs: diff --git a/db/migrate/20250429102109_rename_site_setting_content_translation.rb b/db/migrate/20250429102109_rename_site_setting_content_translation.rb new file mode 100644 index 00000000..96964804 --- /dev/null +++ b/db/migrate/20250429102109_rename_site_setting_content_translation.rb @@ -0,0 +1,19 @@ +# frozen_string_literal: true + +class RenameSiteSettingContentTranslation < ActiveRecord::Migration[7.2] + def up + execute <<~SQL + UPDATE site_settings + SET name = 'experimental_content_translation' + WHERE name = 'experimental_category_translation'; + SQL + end + + def down + execute <<~SQL + UPDATE site_settings + SET name = 'experimental_category_translation' + WHERE name = 'experimental_content_translation'; + SQL + end +end diff --git a/spec/jobs/translate_categories_spec.rb b/spec/jobs/translate_categories_spec.rb index 0392ad71..dc50eeea 100644 --- a/spec/jobs/translate_categories_spec.rb +++ b/spec/jobs/translate_categories_spec.rb @@ -1,7 +1,5 @@ # frozen_string_literal: true -require "rails_helper" - describe Jobs::TranslateCategories do subject(:job) { described_class.new } @@ -15,7 +13,7 @@ def localize_all_categories(*locales) before do SiteSetting.translator_enabled = true - SiteSetting.experimental_category_translation = true + SiteSetting.experimental_content_translation = true SiteSetting.automatic_translation_backfill_rate = 100 SiteSetting.automatic_translation_target_languages = "pt|zh_CN" @@ -31,8 +29,8 @@ def localize_all_categories(*locales) job.execute({}) end - it "does nothing when experimental_category_translation is disabled" do - SiteSetting.experimental_category_translation = false + it "does nothing when experimental_content_translation is disabled" do + SiteSetting.experimental_content_translation = false translator.expects(:translate_text!).never