DEV: Locale normalizer #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that locales returned by the translator provider are normalized before being saved to Post.locale for direct mapping to I18n values.
- Updated tests in post_locale_detector_spec.rb to expect normalized locales.
- Introduced the LocaleNormalizer module with corresponding tests.
- Modified post_locale_detector to update Post.locale with the normalized locale.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/services/post_locale_detector_spec.rb | Adjusted tests to verify locale normalization outcomes. |
| spec/lib/locale_normalizer_spec.rb | Added new tests to validate the LocaleNormalizer functionality. |
| lib/discourse_translator/locale_normalizer.rb | Created the LocaleNormalizer module for mapping locales. |
| app/services/discourse_translator/post_locale_detector.rb | Updated locale assignment to include normalization. |
lis2
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Localize locales that get returned by the translator provider before saving them into the
Post.locale. This helps with direct mapping to a I18n value.