FIX: Don't double cook #297
Merged
+354
−401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamSaffron
reviewed
May 13, 2025
| def self.translate_translatable!(translatable, target_locale_sym = I18n.locale) | ||
| detected_lang = detect(translatable) | ||
| def self.translate_post!(post, target_locale_sym = I18n.locale, opts = {}) | ||
| raw = opts.key?(:raw) ? opts[:raw] : !opts[:cooked] |
Member
There was a problem hiding this comment.
generally if we can get away without this pattern I think it is better..
def self.translate_post!(post, locale: I18n.locale, type: :raw)
something a bit clearer sig wise
SamSaffron
approved these changes
May 13, 2025
Member
|
overall I approve, it is well tested, but the interface can be a bit more readable, avoiding opts and being deliberate about params makes stuff a bit clearer |
Contributor
Author
|
Yeah I agree about the interface.. the first step here was to expand to a specific method per model (post + topic) so there would be less opts thrown about. |
nattsw
added a commit
that referenced
this pull request
May 23, 2025
In #203 we introduced a bug for the amazon provider, which was fixed in #297. This commit is a migration to purge the incorrect translations that have been stored. The translation will look like the following as the full response is saved instead of the specific attribute. ``` {translated_text: ... ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug where we were double-cooking when saving
PostLocalizationwhen the AI provider is used.The reason is due to the fact that we used to translate raw, then cook, and save the cooked. But now, we are required to save both the raw and cooked into
PostLocalization.This PR also splits
translate_translatableintotranslate_postandtranslate_topic. Originally they were taking the same route, but it was proving to be a bit annoying because post uses raw and cooked, whereas topic uses title. It makes understanding any issues with a single model (e.g. Posts) easier to understand if it is a single code path. Lastly, PR also fixes an Amazon provider bug as it was never tested.